We Keep Coding

Extract the assignment of from this expression with sonarQube

when I launch a sonar control I find myself with a smells code for the following function:
const changeMedia = (value: any, step: any) => {
step.definition?.steps
.filter((obj: any) => obj.media.includes(value))
.map((item: any) => {
if (value === 'EMAIL') {
return (item.media = 'LETTER');
} else if (value === 'LETTER') {
return (item.media = 'EMAIL');
}
return item;
});
};
I get the following sonar alert:
Extract the assignment of "item.media" from this expression.
What would be the solution to avoid this sonar message?

const changeMedia = (value, step) => {
step.definition?.steps
.filter((obj) => obj.media.includes(value))
.map((item) => {
if (value === 'EMAIL') {
item.media = 'LETTER'
return item; // returning item instead of (item.media = 'LETTER')
} else if (value === 'LETTER') {
item.media = 'EMAIL'
return item;
}
return item;
});
};

Run a function recursivelly in Javascript

I created this function:
const demoD = (
obj,
toChange,
newV,
) => {
return Object.keys(obj).reduce((acc, key) => {
if (typeof obj[key] === 'object') {
demoD(obj[key], toChange, newV);
}
acc[key] = obj[key] === toChange ? newV : obj[key]
return acc
}, {})
}
const obj = {
name: '',
age: '687',
demo: {
test: ''
}
}
console.log(demoD(obj, '', null))
The idea of this function is to change a value from the object with a new one, and it should run recursivelly. I expect this result:
const obj = {
name: null',
age: '687',
demo: {
test: null'
}
}
But i don't get this result, and the test still unchanged. Question: How to fix and what is the issue?

If you want to apply change to the original object in place:
const demoD = (
obj,
toChange,
newV,
) => {
return Object.keys(obj).reduce((acc, key) => {
if (typeof obj[key] === 'object') {
demoD(obj[key], toChange, newV);
}
acc[key] = obj[key] === toChange ? newV : obj[key]
return acc
}, obj) // 👈 send in obj here
}
If you don’t want to mutate your original object, then it should be:
const demoD = (
obj,
toChange,
newV,
) => {
return Object.keys(obj).reduce((acc, key) => {
if (typeof obj[key] === 'object') {
acc[key] = demoD(obj[key], toChange, newV)
} else {
acc[key] = obj[key] === toChange ? newV : obj[key]
}
return acc
}, {})
}

search array within a object in javascript / typescript

I want to find the first array in an object in Javascript. However my functions cause an error:
el is undefined
el contains the object that looks like this:
data = {
foo: {
bar: [{object a},
{object b},
{object c}
]
}
}
let el = data;
el = this.searchArray(el);
el.forEach(element => {
console.log(element);
let siblingData = this.injectFilterParameters(element);
});
//here is unimportant code
searchArray(obj) {
if (Array.isArray(obj)) {
return obj;
} else {
Object.keys(obj).forEach(key => {
if (Array.isArray(obj[key])) {
return obj[key];
} else {
return this.searchArray(obj[key]);
}
})
}
}

const data = {
foo: {
bar: [
{ object: 'a' },
{ object: 'b' },
{ object: 'c' }
]
}
}
console.log(findArray(data))
function findArray(data: unknown): unknown[] | undefined {
if (Array.isArray(data)) {
return data
}
if (typeof data !== 'object') {
return undefined
}
const object = data as Record<string, unknown>
for (const key of Object.keys(object)) {
const value = object[key]
const valueSearchResult = findArray(value)
if (valueSearchResult != undefined) {
return valueSearchResult
}
}
return undefined
}

Check for non null array during filtering an object

Trying to filter the object to return only non null values.
Below is excerpt from my code. How do I check for non null values in the array job in this case?
const name = null,
age = '25',
job = [null];
const obj = {
name,
age,
job
};
const result = Object.fromEntries(
Object.entries(obj).filter(([_, value]) => value)
);
console.log(result)
Could anyone please help?
I was expecting the result to be
{
"age": "25"
}

First map the array in the entries to keep only truthy values, then filter the entries by whether the entry is truthy and not a 0-length array:
const name = null,
age = '25',
job = [null];
const obj = {
name,
age,
job
};
const result = Object.fromEntries(
Object.entries(obj)
.map(
([key, value]) => [key, Array.isArray(value) ? value.filter(v => v) : value]
)
.filter(([, value]) => value && (!Array.isArray(value) || value.length))
);
console.log(result)

If your arrays can only have one element, you can check if the value[0] is truthy as well.
const name = null,
age = '25',
job = [null];
const obj = {
name,
age,
job
};
const result = Object.fromEntries(
Object.entries(obj).filter(([_, value]) => value && value[0])
);
console.log(result)

This can be done as follows:
const name = null,
age = '25',
job = [null, 29];
const obj = {
name,
age,
job
};
let result = {
}
for (prop in obj) {
if (obj[prop]) {
if (Array.isArray(obj[prop])) {
result[prop] = obj[prop].filter(function (element) {
return element != null;
})
}
else {
result[prop] = obj[prop];
}
}
}
console.log(result)

How to check if an object property is undefined without a for in loop?

Say I have a function,
const doSomething = (a : String, b : Object) => {
const something = 'something';
if (!a) {
throw new Error(
'a is missing'
);
}
for (let prop in b) {
if (b[prop] === undefined) { // erroneously previously if (!b[prop])
throw new Error(
`prop ${prop} in b is missing`
);
}
}
return something;
}
Is there any way to avoid the for..in loop, and somehow check for an undefined property in b without it?
Something like,
const doSomething = (a : String, b : Object) => {
const something = 'something';
if (!a || Object.values(b.includes(undefined))) {
throw new Error(
`${!a ? 'a is missing' : 'b contains undefined'}`
);
}
return something;
}
But ideally I'd like something a little cleaner and to know the actual undefined prop.

You can use Object.entries and Array.some to determine if any property is undefined
function hasUndefinedValue(obj){
return Object.entries(obj).some(e => typeof e[1] === 'undefined');
}
Example below has a few test cases.
function hasUndefinedValue(obj){
return Object.entries(obj).some(e => typeof e[1] === 'undefined');
}
var tests = [
{a:"foo"},
{a:"foo", b: undefined},
{a:"foo",b:[1,2,3]}
];
for(var i = 0;i<tests.length;i++){
console.log(tests[i],hasUndefinedValue(tests[i]));
}

You can use Object.keys().
const obj = {
a: 'val',
b: undefined
};
Object.keys(obj)
.forEach(key => {
if(!obj[key]) {
throw new Error(`prop ${key} has undefined value`)
}
});
--Edit--
const obj = {
a: 'val',
b: false
};
Object.keys(obj)
.forEach(key => {
if(!obj[key]) {
throw new Error(`prop ${key} has undefined value`)
}
});
If only undefined case needs to be handled, then you achieve it by using obj[key] == undefined.