We Keep Coding

How to edit a specific line of a text file with javascript

I am clueless of how to do this, I am trying to edit the second line of a text file imported in html. This is my code so far:
let AddedItems = '';
function GenerateCode() {
const Out = document.getElementById("Output").value
const Quantity = document.getElementById("OutQuantity").value
const Time = document.getElementById("Time").value
if(Quantity < 1) return alert('You need to set a quantity greater than 0');
if(Time < 0) return alert('You need to set a time of aleast 0');
if(Out === '') return alert('You need to set a output item');
document.getElementById("CodeOut").innerHTML = ',{"itemId": "' + Out + '", "quantity": ' + Quantity + ', "craftTime": ' + Time + ', "ingredientList": [' + AddedItems + ']}';
}
function ResetItems() {
AddedItems = '';
GenerateCode();
}
function AddItem() {
const ItemQ = document.getElementById("IimeQ").value;
const Input = document.getElementById("Input").value;
if(ItemQ < 1) return alert('You need to set a quantity greater than 0');
if(Input === '') return alert('You need to set a input');
if(AddedItems === '') {
AddedItems = '{ "quantity": ' + ItemQ + ', "itemId": "' + Input + '"}';
} else {
AddedItems = AddedItems.concat(', { "quantity": ' + ItemQ + ', "itemId": "' + Input + '"}');
}
GenerateCode();
}
it is just calling functions when a button is clicked, but I need another function to get a text file and change the second to last line to "document.getElementById("CodeOut").innerHTML"

Use the FileReader API and pass the data from the file input. You can then split by line breaks and read it in as an array (if the file isn't massive, otherwise you should use some sort of a buffer)
document.getElementById('inputfile').addEventListener('change', function() {
const fr=new FileReader();
fr.onload=function(){
document.getElementById('output')
.textContent=fr.result;
}
let text = fr.readAsText(this.files[0]);
/*Split by a regex that looks at windows (\n)
and unix (\r) line breaks, then get the second line.*/
text.split(/[\r\n]+/g)[1];
})

Recursive Function not working correctly

I have a recusive function that is supposed to loop through a json object and output the expression. However, my recusion seems to be off because it's outputting field1 != '' AND field3 == '' when it should be outputting field1 != '' AND field2 == '' AND field3 == ''
I've tried a couple different things and the only way I can get it to work is by creating a global variable outstring instead of passing it to the function. Where am I off? When I step through it, i see a correct result but once the stack reverses, it start resetting outstring and then stack it back up again but leaves out the middle (field2).
JSFiddle
function buildString(json, outstring) {
var andor = json.condition;
for (var rule in json.rules) {
if (json.rules[rule].hasOwnProperty("condition")) {
buildString(json.rules[rule], outstring);
} else {
var field = json.rules[rule].id;
var operator = json.rules[rule].operator;
var value = json.rules[rule].value == null ? '' : json.rules[rule].value;
outstring += field + ' ' + operator + ' ' + value;
if (rule < json.rules.length - 1) {
outstring += ' ' + andor + ' ';
}
}
}
return outstring;
}
var jsonObj = {"condition":"AND","rules":[{"id":"field1","operator":"!= ''","value":null},{"condition":"AND","rules":[{"id":"field2","operator":"== ''","value":null}]},{"id":"field3","operator":"== ''","value":null}]};
$('#mydiv').text(buildString(jsonObj, ""));

The function has a return of a string.
When you call the function recursively from within itself, you aren't doing anything with the returned string from that instance, just calling the function which has nowhere to return to
Change:
if (json.rules[rule].hasOwnProperty("condition")) {
buildString(json.rules[rule], outstring);
}
To
if (json.rules[rule].hasOwnProperty("condition")) {
// include the returned value in concatenated string
outstring += buildString(json.rules[rule], outstring);
}
DEMO

Why so complicated?
function buildString(obj) {
return "condition" in obj?
obj.rules.map(buildString).join(" " + obj.condition + " "):
obj.id + " " + obj.operator + " " + string(obj.value);
}
//this problem occurs quite often, write a utility-function.
function string(v){ return v == null? "": String(v) }

How to setup if-statement with multiple conditions, which uses the valid condition's variable in the if-statement?

Okay, that title will sound a bit crazy. I have an object, which I build from a bunch of inputs (from the user). I set them according to their value received, but sometimes they are not set at all, which makes them null. What I really want to do, it make an item generator for WoW. The items can have multiple attributes, which all look the same to the user. Here is my example:
+3 Agility
+5 Stamina
+10 Dodge
In theory, that should just grab my object's property name and key value, then output it in the same fashion. However, how do I setup that if-statement?
Here is what my current if-statement MADNESS looks like:
if(property == "agility") {
text = "+" + text + " Agility";
}
if(property == "stamina") {
text = "+" + text + " Stamina";
}
if(property == "dodge") {
text = "+" + text + " Dodge";
}
You get that point right? In WoW there are A TON of attributes, so it would suck that I would have to create an if-statement for each, because there are simply too many. It's basically repeating itself, but still using the property name all the way. Here is what my JSFiddle looks like: http://jsfiddle.net/pm2328hx/ so you can play with it yourself. Thanks!
EDIT: Oh by the way, what I want to do is something like this:
if(property == "agility" || property == "stamina" || ....) {
text = "+" + text + " " + THE_ABOVE_VARIABLE_WHICH_IS_TRUE;
}
Which is hacky as well. I definitely don't want that.

if(['agility','stamina','dodge'].indexOf(property) !== -1){
text = "+" + text + " " + property;
}
If you need the first letter capitalized :
if(['agility','stamina','dodge'].indexOf(property) !== -1){
text = "+" + text + " " + property.charAt(0).toUpperCase() + property.substr(1);
}
UPDATE per comment:
If you already have an array of all the attributes somewhere, use that instead
var myatts = [
'agility',
'stamina',
'dodge'
];
if(myatts.indexOf(property) !== -1){
text = "+" + text + " " + property.charAt(0).toUpperCase() + property.substr(1);
}
UPDATE per next comment:
If you already have an object with the attributes as keys, you can use Object.keys(), but be sure to also employ hasOwnProperty
var item = {};
item.attribute = {
agility:100,
stamina:200,
dodge:300
};
var property = "agility";
var text = "";
if(Object.keys(item.attribute).indexOf(property) !== -1){
if(item.attribute.hasOwnProperty(property)){
text = "+" + text + " " + property.charAt(0).toUpperCase() + property.substr(1);
}
}
Fiddle: http://jsfiddle.net/trex005/rk9j10bx/
UPDATE to answer intended question instead of asked question
How do I expand the following object into following string? Note: the attributes are dynamic.
Object:
var item = {};
item.attribute = {
agility:100,
stamina:200,
dodge:300
};
String:
+ 100 Agility + 200 Stamina + 300 Dodge
Answer:
var text = "";
for(var property in item.attribute){
if(item.attribute.hasOwnProperty(property)){
if(text.length > 0) text += " ";
text += "+ " + item.attribute[property] + " " + property.charAt(0).toUpperCase() + property.substr(1);
}
}

It's unclear how you're getting these values an storing them internally - but assuming you store them in a hash table:
properties = { stamina: 10,
agility: 45,
...
}
Then you could display it something like this:
var text = '';
for (var key in properties) {
// use hasOwnProperty to filter out keys from the Object.prototype
if (h.hasOwnProperty(k)) {
text = text + ' ' h[k] + ' ' + k + '<br/>';
}
}
After chat, code came out as follows:
var item = {};
item.name = "Thunderfury";
item.rarity = "legendary";
item.itemLevel = 80;
item.equip = "Binds when picked up";
item.unique = "Unique";
item.itemType = "Sword";
item.speed = 1.90;
item.slot = "One-handed";
item.damage = "36 - 68";
item.dps = 27.59;
item.attributes = {
agility:100,
stamina:200,
dodge:300
};
item.durability = 130;
item.chanceOnHit = "Blasts your enemy with lightning, dealing 209 Nature damage and then jumping to additional nearby enemies. Each jump reduces that victim's Nature resistance by 17. Affects 5 targets. Your primary target is also consumed by a cyclone, slowing its attack speed by 20% for 12 sec.";
item.levelRequirement = 60;
function build() {
box = $('<div id="box">'); //builds in memory
for (var key in item) {
if (item.hasOwnProperty(key)) {
if (key === 'attributes') {
for (var k in item.attributes) {
if (item.attributes.hasOwnProperty(k)) {
box.append('<span class="' + k + '">+' + item.attributes[k] + ' ' + k + '</span>');
}
}
} else {
box.append('<span id="' + key + '" class="' + item[key] + '">' + item[key] + '</span>');
}
}
}
$("#box").replaceWith(box);
}
build();
http://jsfiddle.net/gp0qfwfr/5/

Can't save id to a variable

I'm having trouble assigning an id field to a variable.
Given this:
var temp;
if(!data.obj.id){
console.log('*************** assigning ' + data.obj.id + ' to temp');
temp = data.obj.id;
console.log('temp is',temp);
}else if(!data.obj._id){
console.log('*************** assigning ' + data.obj._id + ' to temp');
temp = data.obj._id;
console.log('temp is: ',temp);
}
console.log('**************',data.obj._id);
console.log('**************',temp);
Neither of those if statements are ever true, and the console logs return,
************ 538cdd6fca343660389d4d69
************ undefined
EDIT:
I've also tried:
if(data.obj.hasOwnProperty('id')){
console.log('*************** assigning ' + data.obj.id + ' to temp');
temp = data.obj.id;
console.log('temp is',temp);
}else if(data.obj.hasOwnProperty('_id')){
console.log('*************** assigning ' + data.obj._id + ' to temp');
temp = data.obj._id;
console.log('temp is: ',temp);
}
console.log('**************',data.obj._id);
console.log('**************',temp);
And temp is still undefined.
EDIT2:
I've changed my code to this:
var temp;
if(data.obj.hasOwnProperty('id')){
console.log('*************** assigning ' + data.obj.id + ' to temp');
temp = data.obj.id;
console.log('temp is' + temp);
}
if(data.obj.hasOwnProperty('_id')){
console.log('*************** assigning ' + data.obj._id + ' to temp');
temp = data.obj._id;
console.log('temp is' + temp);
}
console.log('**************',data.obj._id);
console.log('**************',data.obj.id);
console.log('**************',temp);
And I get:
************** 538ce08c6ced88c020ecbd07
************** 538ce08c6ced88c020ecbd07
************** undefined

You didn't log the value of data.obj.id, but presumably it is also true, like _id (in the sense that their negation returns false). Therefore, neither the first nor the second if clause are fulfilled in your example, and none of the two branches execute. It seems like you want to remove the negation operators, !, from both your if clauses, but it's hard to tell without context.

if doesn't work in javascript function

I use this function to validate one input element :
function validerInput(qte, qtemax) {
var floatRegex = /^((\d+(\.\d *)?)|((\d*\.)?\d+))$/;
if (floatRegex.test(qte.value)) {
var a = qte.value;
var b = qtemax;
if (a > b) {
alert('if qtemax : ' + qtemax + ', qte : ' + qte.value);
qte.value = '';
}
else {
alert('else qtemax : ' + qtemax + ', qte : ' + qte.value);
}
}
else {
qte.value = '';
}
}
but the problem is always the alert of else is launched and the first never I don't know the problem
do you have any idea :
the alert that is launched contains for example 234 and 5.66

The value property of an input element is stored as a string, so if you want to treat it as a number you'll need to convert it to one. You may have a similar issue with the value of qtemax too, it's impossible to say. Comparing strings alphabetically "234" comes before "5.66", then though numerically it's (much) greater. Use the parseFloat function:
var a = parseFloat(qte.value),
b = parseFloat(qtemax);