I am currently using google forms to enable users to submit site changes. This is all working beautifully.
I have added an extra column that has ticket status. Now I have written a script that checks for when this is updated to Done and then moves that row into another sheet entitled done.
However this only works if i update a row that i manually added. If I change the column on a row created from the form entry it will not work. Has anyone seen this issue before. Code is below.
function onEdit(e){
/*
When a user updates a status to done the ticket gets moved to another sheet
*/
var sheetNameToWatch = "Form responses 1"; // The sheet to watch for changes
var columnNumberToWatch = 1; // The column where the change happens on the above sheet
var valueToWatch = "Done"; // What is the text you are looking for
var sheetNameToMoveTheRowTo = "Done"; // The Sheet name for where the row gets moved to.
var ss = SpreadsheetApp.getActiveSpreadsheet(); // Get the active spreadsheet
var sheet = SpreadsheetApp.getActiveSheet(); // Get the active sheet
var range = sheet.getActiveCell(); // Get the current cell that has just been updated
// Check that you are on the correct sheet and column.
if (sheet.getName() == sheetNameToWatch && range.getColumn() == columnNumberToWatch && range.getValue() == valueToWatch) {
var targetSheet = ss.getSheetByName(sheetNameToMoveTheRowTo); // get a reference for the target sheet
var targetRange = targetSheet.getRange(targetSheet.getLastRow() + 1, 1); // get a reference for the target row
sheet.getRange(range.getRow(), 1, 1, sheet.getLastColumn()).moveTo(targetRange); // copy the row from current sheet to the new sheet
sheet.deleteRow(range.getRow()); // Delete the row from the old sheet
}
}
Yep, the onEdit function won't fire unless you do it manually, you'll want to use the onFormSubmit trigger, which will fire when a form response is received. This is a manually installed trigger connected to your form, which should be able to do the function above pretty much as written.
var form = FormApp.openById('1234567890abcdefghijklmnopqrstuvwxyz');
ScriptApp.newTrigger('myFunction')
.forForm(form)
.onFormSubmit()
.create();
To be safe, though, you may want to define your spreadsheet, sheet, and range by id or by name rather than by whether they are active, I believe getActiveWhatever() kinds of methods will return null if the spreadsheet isn't open.
As mentioned, using active is not the best idea.
Instead of:
var ss = SpreadsheetApp.getActiveSpreadsheet(); // Get the active spreadsheet
var sheet = SpreadsheetApp.getActiveSheet(); // Get the active sheet
var range = sheet.getActiveCell(); // Get the current cell that has just been updated
Try:
var range = e.range;
var sheet = range.getSheet();
var ss = sheet.getParent();
If you try this you cannot execute it from the code editor because no event is passed. You must execute it by actually submitting a form.
Related
I am trying to use an onEdit trigger when a specific tab in a sheet is edited and copy it over to a specific tab in another sheet. For example: If there is any change in Sheet 1 Test 1 tab then it will copy whatever is in Sheet 1 Test 1 tab onto Sheet 2 Test 1. But if the change is in Sheet 1 Test 2 tab then it will copy whatever is in Sheet 1 Test 2 tab onto Sheet 2 Tab 2 tab.
I am able to do it for manual copy and pasting only(i can successfully copy Sheet 1 Test 1 tab to Sheet 2 Test 1 tab or Sheet 1 Test 2 tab to Sheet 2 Test 2 tab) but when I add the onEdit trigger and if loops on my code(for specifying where the edit happened and where the source and destination tabs will be) then the code doesn't run.
Here are my 2 codes(1st will be the if else loop to specify source and destination and 2nd will be the onEdit trigger):
Code 1
function test1()
{var sheet = SpreadsheetApp.getActiveSheet().getSheetName()
if(sheet == 'Test 1') {
//your script
var sss = SpreadsheetApp.openById('1xk1ayrBYXCDdHcIwi7Hukq1xnNjqSTsQ7CHQbzfFiRM'); //replace with source ID
var ss = sss.getSheetByName('Test 1');
var sr = ss.getRange("A1:N25");
var data = sr.getValues();
var tss = SpreadsheetApp.openById('1Ut-eyO3FMBApQd62ewtINmIQSQJSDL7DCU5bRIzdBVY'); //replace with destination ID
var ts = tss.getSheetByName('Test 1');
var tr = ts.getRange("A1:N25");
tr.setValues(data);
}
else if(sheet == 'Test 2') {
//your script
var sss = SpreadsheetApp.openById('1xk1ayrBYXCDdHcIwi7Hukq1xnNjqSTsQ7CHQbzfFiRM'); //replace with source ID
var ss = sss.getSheetByName('Test 2');
var sr = ss.getRange("A1:N25");
var data = sr.getValues();
var tss = SpreadsheetApp.openById('1Ut-eyO3FMBApQd62ewtINmIQSQJSDL7DCU5bRIzdBVY'); //replace with destination ID
var ts = tss.getSheetByName('Test 2');
var tr = ts.getRange("A1:N25");
tr.setValues(data);
}
}
Code 2
function createEditTrigger() {
ScriptApp.newTrigger("test 1")
.forSpreadsheet(SpreadsheetApp.getActive())
.onEdit()
.create();
}
Here are my sample sheets:
Sample Sheet 1: https://docs.google.com/spreadsheets/d/1xk1ayrBYXCDdHcIwi7Hukq1xnNjqSTsQ7CHQbzfFiRM/edit#gid=0
Sample Sheet 2:
https://docs.google.com/spreadsheets/d/1Ut-eyO3FMBApQd62ewtINmIQSQJSDL7DCU5bRIzdBVY/edit#gid=921178690
What would be the best way to approach this if I only need to copy changes in sheet 1 into sheet 2? I dont need to monitor if any changes happens in sheet 2 nor do I need to copy anything from sheet 2 to sheet 1.
SpreadsheetApp.openById() require authorization and onEdit() cannot perform operations that require permission. You must use an installable trigger.
I already try everthing but I cant make this work =/
I'm trying to copy data from one spreadsheet to other using setValues(), because link doesn't work for me. I also need to keep the trigger on edit.
So, I create one fuction called AddConvocacao, and always when have any change the script run.
function addConvocacao(e){
var linha = e.range.getRow(); //get the number of the line, where have edit
var nome = e.source.getActiveSheet().getRange(linha,2).getValue(); //get the value of the field
var targetSheet = SpreadsheetApp.openById('1iQbZ7iB9ddc-HwLK9vG0eVEeWWqXKJZ0ry7U_Hm4SkQ') //open the other spreedsheet
var targetName = targetSheet.getSheetByName('Pac'); //open the tab
var lastRow = targetName.getLastRow(); //count the last row in this tab
lastRow = lastRow+1; //add 1
targetName.getRange(lastRow, 2).setValue(nome); // set the value
// targetName.getRange(lastRow, 3).setValue(valorCol7);
// targetName.getRange(lastRow, 5).setValue(dose);
// targetName.getRange(lastRow, 6).setValue(diagnostico);
// targetName.getRange(lastRow, 7).setValue(medico);
}
why dosen't work when I use on edit?
Thanks so much! =)
I did it a little different I think. I put checkboxes in column one and capture the value from column 2 and sent it to the other spreadsheet to the bottom of column 2
function onMyEdit(e) {
//e.source.toast('entry');
const sh = e.range.getSheet();
//Logger.log(JSON.stringify(e));
if (sh.getName() == 'Sheet1' && e.range.columnStart==1 && e.value=="TRUE") {
//e.source.toast('cond');
const v = sh.getRange(e.range.rowStart, 2).getValue();
var tss = SpreadsheetApp.openById(getGlobal('targetid'));
var tsh = tss.getSheetByName('Sheet1');
tsh.getRange(tsh.getLastRow() + 1, 2).setValue(v);
e.range.setValue("FALSE");
}
}
You must use an installable trigger to us openById();
getGlobal(targetid) just gets a spreadsheet id you can replace that with the id
Also I limited the action to only one sheet and only when I set the checkbox to true. I reset it back to false in the code.
You'll need to modify a few things to get it to work for you because when I'm doing the examples I do it my way.
I'm very, very new to JavaScript and Google Sheets. I'm trying to learn it, but it's very confusing.
I have a row of checkboxes in Sheet1, cells E4 to L4.
Below them, I have a button.
What I want to happen is, when you click the button:
If ANY of the checkboxes in cells E4 to L4 are UNCHECKED, then set them ALL to be CHECKED.
IF, however, ALL the checkboxes in E4 to L4 are already CHECKED, then set them ALL to be UNCHECKED.
This is what I have so far:
function ToggleALLBoxes() {
var ss = SpreadsheetApp.getActiveSpreadsheet();
var sheet = ss.getSheetByName("Sheet1");
var range = sheet.getRange('E4:L4');
var value = range.getValue();
Any ideas?
You can achieve it using one button, by applying a toggle in the script like so:
function ToggleALLBoxes() {
var ss = SpreadsheetApp.getActiveSpreadsheet();
var sheet = ss.getSheetByName("Sheet1");
var range = sheet.getRange('E4:L4');
var values = range.getValues()[0];
if(values.indexOf(false) < 0){
Logger.log("All checked")
// Set them to unchecked
range.setValue("FALSE");
}else {
Logger.log("Not all checked")
// Set all to checked
range.setValue("TRUE");
}
}
And assigning the function to the image of the button like:
I created a function that's tied to a custom menu item in a google spreadsheet and is meant to detect the current row and perform some checking. The issue is that every time i run the menu item > script it always detect row 1 and not the current script. here's the code for reference:
function updateCalendarItems(){
//this function detects the current row and updates the main and follow up calendar events
//Get the current row
var ss = SpreadsheetApp.openById('<deleted>');
var sheet = ss.getSheetByName('db_clientvisit');
Logger.log('Sheet Name: '+sheet.getName()); //this logs the correct sheet name
// var range = sheet.getActiveCell();
var rowNum = sheet.getActiveCell().getRow();
Logger.log(rowNum); //always logs 1
var range = sheet.getRange(rowNum, 1, 1, 13).getValues(); //always returns the first row
Logger.log(range);
var ui = SpreadsheetApp.getUi();
ui.alert('Row Num is :'+rowNum+' Column Num is: '+sheet.getActiveCell().getColumn());
return;
var range = sheet.getRange(rowNum, 1, 1, 13);
var row = range.getValues()[0];
Logger.log(row);
//open the calendar
var calendarID = 'loveyourself.ph_umvj5k6vo45ei0mbh423g97ebg#group.calendar.google.com';
var calendar = CalendarApp.getCalendarById(calendarID);
//update the calendar...
}
Use var ss = SpreadsheetApp.getActive().
When you use SpreadsheetApp.openById('<deleted>'), you're essentially opening up a new session of the spreadsheet instead of your active session. So Apps Script isn't able to get the "active" ranges.
Similarly, you may also want to try using SpreadsheetApp.getCurrentCell().
function updateCalendarItems() {
var currentCell = SpreadsheetApp.getCurrentCell();
var rowNum = currentCell.getRow();
var ui = SpreadsheetApp.getUi();
ui.alert('Row Num is :'+rowNum+' Column Num is: '+currentCell.getColumn());
return;
}
I am using Gdocs spreadsheet for jobs queue.
I would like to know how a row and all its content (from column A:AS) can be moved from "Live WIP Jobs" (sheet1) Tab to "Delivered Jobs" (Sheet2) Tab by marking it as "Delivered" in Column "AP".
Normally it will be marked as WIP in sheet1.
On marking it as Delivered, I would like the row to copied to the Sheet2 and get it removed from sheet1.
Attaching sheet for reference
https://docs.google.com/spreadsheets/d/1gZYni8SGUa4Ohu3BIOxJh2bQSUqQh_5Q3epDidP574E/edit#gid=1557156093
I also tried the below script.. but it wasn't working and fetching error:
function CopyRowsOnConditions() {
// assumes source data in sheet named Live WIP Jobs
// target sheet of move to named Delivered
// test column with Delivered/WIP is col AP or 42
var sheet = SpreadsheetApp.getActiveSheet();
var numRows = sheet.getDataRange().getNumRows();
var source = sheet.getRange(2, 42, numRows);
if(s.getName() == "Live WIP Jobs" && r.getColumn() == 42 && r.getValue() == "Delivered"){
var row = r.getRow();
var numColumns = s.getLastColumn();
var targetSheet = ss.getSheetByName("Delivered");
if(targetSheet.getLastRow() == targetSheet.getMaxRows()) {
targetSheet.insertRowsAfter(targetSheet.getLastRow(), 20); //inserts 20 rows after last used row
}
var target = targetSheet.getRange(targetSheet.getLastRow() + 1, 1);
s.getRange(row, 1, 1, numColumns).moveTo(target);
s.deleteRow(row);
}
}
Checking the code in the script (the one you posted was not complete) i noticed that you are creating the variables "r" and "s" using the variable "event".
When you have a event (eg. onEdit) the function receives a parameter event, then you can us it. here is information in those events https://developers.google.com/apps-script/guides/triggers/events
If you are going to use an event, change the code accordingly, as mention in the documentation.