clearRect of canvas context does not clear the pixels - javascript
I want to make an animation with javascript and html canvas, just the make a rectangle move from the top of the window to the bottom, I use canvas.clearRect to clear all the pixel on the canvas, but, it seems this function does not work, the previously drawing was still there. here is all the code
<!DOCTYPE HTML>
<html>
<title>Jave script tetris by zdd</title>
<head>
<script>
function point(x, y)
{
this.x = x;
this.y = y;
}
function draw(timeDelta)
{
// Vertices to draw a square
var v1 = new point( 0, 0);
var v2 = new point(100, 0);
var v3 = new point(100, 100);
var v4 = new point( 0, 100);
this.vertices = [v1, v2, v3, v4];
// Get canvas context
var c = document.getElementById("canvas");
var cxt = c.getContext("2d");
// Clear the canvas, this does not work?
cxt.clearRect(0, 0, 800, 600);
// Move the piece based on time elapsed, just simply increase the y-coordinate here
for (var i = 0; i < this.vertices.length; ++i)
{
this.vertices[i].y += timeDelta;
}
cxt.moveTo(this.vertices[0].x, this.vertices[0].y);
for (var i = 1; i < this.vertices.length; ++i)
{
cxt.lineTo(this.vertices[i].x, this.vertices[i].y);
}
cxt.lineTo(this.vertices[0].x, this.vertices[0].y);
cxt.stroke();
}
var lastTime = Date.now();
function mainLoop()
{
window.requestAnimationFrame = window.requestAnimationFrame ||
window.mozRequestAnimationFrame ||
window.webkitRequestAnimationFrame ||
window.msRequestAnimationFrame;
window.requestAnimationFrame(mainLoop);
var currentTime = Date.now();
var timeDelta = (currentTime - lastTime);
draw(timeDelta);
lastTime = currentTime;
}
</script>
</head>
<body>
<canvas id="canvas" width="800" height="600">
</canvas>
<script>
</script>
<button type="button" style="position:absolute; left:500px; top:600px; width:100px; height:50px;" class="start" onclick="mainLoop()">start</button>
</body>
</html>
and here is the result picture in Chrome, I want only one rectangle, but the clearRect function didn't clear the old rectangle, so..., how to fix this?
You are missing beginPath. Without it each box is actually part of the last box.
cxt.beginPath();
cxt.moveTo(this.vertices[0].x, this.vertices[0].y);
for (var i = 1; i < this.vertices.length; ++i) {
cxt.lineTo(this.vertices[i].x, this.vertices[i].y);
}
after adding that, the box seems to jiggle around, not sure if thats your intention.
Here's a fiddle: http://jsfiddle.net/6xbQN/
Good luck!
Related
Drawing objects on canvas created by eventlisteners()
I am new to JavaScript and I am having a hard time understanding how to get the canvas to cooperate with stuff I want to do. I am trying to have my HTML button outside the canvas create a rectangle on the canvas. Then I want the rectangle to fall. I have the canvas animated, I have the button set to create a rectangle at user inputted coordinates, but...the canvas won't animate it. It won't fall like the statically created rectangles. I also am struggling with how to get my button to create a new rectangle each time instead of redrawing the same one? Hoping someone can explain more than just give me the code. Thanks in advance. var c = document.getElementById("myCanvas"); var ctx = c.getContext("2d"); window.onload = addListeners; function addListeners() { document.getElementById('b1').addEventListener('click',btn1,false); function btn1() { var inputx = document.getElementById("work").value; var inputy = document.getElementById("y").value; var inputs = document.getElementById("s").value; new Rectangle(inputx,inputy,inputs); // rec.x = inputx; //rec.y = inputy; //rec.s = inputs; } } var r2 = new Rectangle(500, 50, 50); var rec = new Rectangle(); //animate function animate() { requestAnimationFrame(animate); ctx.clearRect(0,0,1450,250); r2.draw(); r2.update(); rec.draw(); rec.update(); } code for rectangle: function Rectangle(x,y,s){ this.x = x; this.y = y; this.s = s; this.draw = function(){ //console.log('fuck'); ctx.fillStyle = "rgba(0,200,0,1)"; ctx.fillRect(this.x,this.y,this.s,this.s); } this.update = function(){ console.log(this.y); if((this.y + this.s) <= 250){ this.y= this.y+2; } } }
The button is not animating anything as the animate method was not being called. Also in your code when you called animate it ended in an infinite loop as requestAnimationFrame will continue to call animate repeatedly, so I've added a condition around requestAnimationFrame(animate) to check the squares height and stop running it when it reaches the bottom, similar to what you had in your update function. To create a new square every time you click the button, I moved the creation of the Rectangles inside the btn1 function. If you want to keep the old squares while creating new ones, you will need to keep track of them outside the canvas and redraw them with everything else each animation. I guessed what your html looks like, but you can run the code below it will drop two squares, but note that the stop condition is only on the hard coded one. var c = document.getElementById("myCanvas"); var ctx = c.getContext("2d"); document.getElementById("b1").addEventListener("click", btn1, false); var r2; var rec; function btn1() { var inputx = document.getElementById("work").value; var inputy = document.getElementById("y").value; var inputs = document.getElementById("s").value; r2 = new Rectangle(500, 50, 50); rec = new Rectangle(parseInt(inputx, 10), parseInt(inputy, 10), parseInt(inputs, 10)); animate(); } //animate function animate() { if (r2.y + r2.s <= 400) { requestAnimationFrame(animate); } ctx.clearRect(0,0,1450,400); r2.draw(); r2.update(); rec.draw(); rec.update(); } function Rectangle(x,y,s){ this.x = x; this.y = y; this.s = s; this.draw = function(){ ctx.fillStyle = "rgba(0,200,0,1)"; ctx.fillRect(this.x,this.y,this.s,this.s); } this.update = function(){ this.y= this.y+2; } } <div> <input id='work'> <input id='y'> <input id='s'> <button id="b1"> Create Sqaure</button> </div> <canvas id="myCanvas" width=600 height=400></canvas>
How to make javascript canvas draw faster?
I have the following code to display an ECG. I use the canvas to draw the graph background (each grid of 2.5 mm dimension). Later I'm taking the y coordinates from an array array_1 (x coordinates are calculated within the program). The problem with this approach is it will take around 40 seconds to plot the entire graph since there are 1250 values within array array_1. What I could do is I could do the plotting part within a loop in which case, the entire graph is plotted as soon as the page is loaded. But, I need the plotting to happen over the course of 5 seconds. Not more. Not less. How would I alter the code to do this? Please help. <!DOCTYPE html> <html> <head> <title></title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <canvas id="canvas" width="1350" height="1300" style="background-color: white;"></canvas> <script type='text/javascript'> var canvas = document.getElementById("canvas"); var ctxt = canvas.getContext("2d"); var n1 = 1; var n1_x=49; //Graph x coordinate starting pixel. var n1_y=72;//Graph y coordinate starting pixel. var array_1 = []// array from which y coordinates are taken. Has 1250 elements var ctx = canvas.getContext("2d"); var x=0; var y=0; var Line_position=-1; while(x<=1350)//graph width { ctxt.lineWidth = "0.5"; Line_position=Line_position+1; if(Line_position%5==0) { ctxt.lineWidth = "1.5"; } ctxt.strokeStyle = "black"; ctxt.beginPath(); ctxt.moveTo(x, 0); ctxt.lineTo(x, 1300); ctxt.stroke(); x=x+9.43; } Line_position=-1; while(y<=1300)//graph height { ctxt.lineWidth = "0.5"; Line_position=Line_position+1; if(Line_position%5==0) { ctxt.lineWidth = "1.5"; } ctxt.strokeStyle = "black"; ctxt.beginPath(); ctxt.moveTo(0, y); ctxt.lineTo(1350,y); ctxt.stroke(); y=y+9.43; } drawWave(); function drawWave() { requestAnimationFrame(drawWave); ctx.lineWidth = "1"; ctx.strokeStyle = 'blue'; ctx.beginPath(); ctx.moveTo(n1_x- 1, n1_y+array_1[n1-1]);//move to the pixel position ctx.lineTo(n1_x, n1_y+array_1[n1]);//Draw to the pixel position ctx.stroke(); n1_x=n1_x+0.374;//Incrementing pixel so as to traverse x axis. n1++; } </script> </body> </html> Here is the array: array_1 = [69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,72,72,72,72,72,72,72,73,73,74,74,74,74,74,74,74,73,73,73,73,74,74,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,74,74,74,73,73,73,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,71,72,72,72,73,73,73,72,72,72,73,73,73,74,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,72,73,73,73,72,72,72,71,101,71,70,70,70,69,68,68,67,67,66,66,67,67,69,70,72,72,72,73,73,74,73,73,73,73,73,73,73,73,73,74,76,77,76,70,57,40,22,11,11,22,40,57,69,73,73,71,71,71,72,72,73,73,74,74,74,73,72,72,72,72,72,72,72,72,72,72,72,72,71,71,70,70,71,71,71,71,70,70,69,69,69,69,69,69,69,68,68,68,67,67,66,66,65,65,64,63,63,62,62,62,62,62,62,62,62,63,63,64,65,66,67,68,68,69,70,71,72,72,72,73,73,73,73,72,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,73,73,73,73,72,73,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,73,73,74,74,74,74,74,74,73,73,72,73,73,73,74,73,73,72,72,72,73,73,73,72,72,73,73,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,71,70,70,70,70,70,69,69,68,67,67,67,67,68,69,71,72,72,73,73,73,73,74,74,74,74,74,73,73,73,73,75,77,78,76,67,53,35,18,8,10,23,41,58,69,73,72,71,70,71,72,73,73,73,73,73,73,73,73,72,72,73,73,73,73,72,71,71,70,70,71,71,71,71,71,71,71,71,70,70,69,69,69,69,68,68,67,67,67,67,67,66,65,65,65,64,63,62,61,61,61,60,60,60,59,60,60,60,61,62,63,65,66,66,67,68,69,70,71,72,72,72,72,73,73,73,72,72,72,72,72,72,72,73,73,73,73,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,71,71,72,72,73,73,73,72,72,72,72,72,72,73,73,73,73,73,73,73,73,73,72,73,73,73,73,73,73,72,73,73,73,73,73,73,73,72,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,71,71,70,70,69,69,69,68,67,67,66,65,66,66,68,69,70,71,72,72,73,73,73,73,73,73,74,74,74,74,74,74,76,78,78,74,64,48,29,13,5,10,26,45,62,71,73,72,71,71,72,73,73,73,73,73,74,74,74,73,72,72,72,73,73,73,73,73,73,73,72,72,72,72,71,71,71,71,71,71,71,71,71,70,70,69,69,69,69,68,67,66,66,66,66,65,65,64,63,62,62,61,61,60,60,60,60,61,62,62,63,64,65,66,67,68,70,71,72,72,72,72,72,72,73,73,73,73,73,73,73,74,74,75,75,74,74,74,73,73,73,74,73,73,73,73,73,74,74,74,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,73,73,74,74,74,73,73,73,73,73,73,73,73,73,73,72,72,72,72,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,73,73,72,72,71,70,70,70,69,69,68,68,67,67,66,67,67,68,69,70,71,72,73,73,74,74,73,73,73,74,75,75,74,73,73,74,76,78,75,67,52,32,15,5,8,22,41,59,69,73,72,71,70,71,72,72,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,72,72,72,72,71,71,71,70,70,70,70,70,70,70,69,69,69,69,68,68,68,68,67,67,66,65,65,64,64,64,63,62,61,60,60,60,60,60,61,61,62,62,63,64,65,65,66,67,68,69,70,71,71,71,71,71,71,72,72,73,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,72,71,71,71,71,71,71,71,72,72,72,72,72,72,72,72,72,71,71,71,72,72,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,73,73,74,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,72,71,71,71,70,70,70,70,69,69,68,67,67,68,69,71,72,73,73,73,73,73,73,73,73,74,75,75,75,74,74,74,75,77,77,75,67,52,34,18,10,12,26,45,62,71,74,73,72,72,72,73,74,74,74,75,75,74,74,74,74,74,74,74,74,74,73,73,73,73,74,74,73,73,73,73,73,73,73,72,72,71,71,71,71,71,70,70,70,69,69,69,68,68,68,68,67,66,65,64,63,63,62,62,62,63,63,63,63,64,65,66,67,69,69,70,71,72,72,73,73,74,74,74,74,75,75,76,76,74,72,70,70,69,69 ];
I'd probably go about the task something like this. As mentioned in a comment, we need to draw a number of the data-points per-frame. How many we draw depends on the speed that the browser is able to supply an animation frame. I've hard-coded the value to 4, since that seems to work on my machine, but with not much more work you can probably make the code time itself and adjust this value on the fly so that your animation runs for as close as possible to the target time. I had a quick go, but the results were awful, I'll leave that as an exercise in research or thought for the reader. By keeping track of how many frames we've already drawn for the current 'refresh-cycle', we know how far to index into the array for the first point to be drawn for each frame. I've tried to parameterize the code as much as possible, but it's late and I'm tired, I may have overlooked something somewhere. <!doctype html> <html> <head> <script> function byId(id,parent){return (parent == undefined ? document : parent).getElementById(id);} window.addEventListener('load', onDocLoaded, false); function onDocLoaded(evt) { drawBkg(byId('canvas'), 9.43, 5, "0.5", "1.5", "black"); drawCurFrame(); } var dataSamples = [69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,20,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,69,72,72,72,72,72,72,72,73,73,74,74,74,74,74,74,74,73,73,73,73,74,74,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,74,74,74,73,73,73,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,71,72,72,72,73,73,73,72,72,72,73,73,73,74,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,72,73,73,73,72,72,72,71,101,71,70,70,70,69,68,68,67,67,66,66,67,67,69,70,72,72,72,73,73,74,73,73,73,73,73,73,73,73,73,74,76,77,76,70,57,40,22,11,11,22,40,57,69,73,73,71,71,71,72,72,73,73,74,74,74,73,72,72,72,72,72,72,72,72,72,72,72,72,71,71,70,70,71,71,71,71,70,70,69,69,69,69,69,69,69,68,68,68,67,67,66,66,65,65,64,63,63,62,62,62,62,62,62,62,62,63,63,64,65,66,67,68,68,69,70,71,72,72,72,73,73,73,73,72,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,73,73,73,73,72,73,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,73,73,74,74,74,74,74,74,73,73,72,73,73,73,74,73,73,72,72,72,73,73,73,72,72,73,73,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,71,70,70,70,70,70,69,69,68,67,67,67,67,68,69,71,72,72,73,73,73,73,74,74,74,74,74,73,73,73,73,75,77,78,76,67,53,35,18,8,10,23,41,58,69,73,72,71,70,71,72,73,73,73,73,73,73,73,73,72,72,73,73,73,73,72,71,71,70,70,71,71,71,71,71,71,71,71,70,70,69,69,69,69,68,68,67,67,67,67,67,66,65,65,65,64,63,62,61,61,61,60,60,60,59,60,60,60,61,62,63,65,66,66,67,68,69,70,71,72,72,72,72,73,73,73,72,72,72,72,72,72,72,73,73,73,73,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,71,71,72,72,73,73,73,72,72,72,72,72,72,73,73,73,73,73,73,73,73,73,72,73,73,73,73,73,73,72,73,73,73,73,73,73,73,72,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,71,71,70,70,69,69,69,68,67,67,66,65,66,66,68,69,70,71,72,72,73,73,73,73,73,73,74,74,74,74,74,74,76,78,78,74,64,48,29,13,5,10,26,45,62,71,73,72,71,71,72,73,73,73,73,73,74,74,74,73,72,72,72,73,73,73,73,73,73,73,72,72,72,72,71,71,71,71,71,71,71,71,71,70,70,69,69,69,69,68,67,66,66,66,66,65,65,64,63,62,62,61,61,60,60,60,60,61,62,62,63,64,65,66,67,68,70,71,72,72,72,72,72,72,73,73,73,73,73,73,73,74,74,75,75,74,74,74,73,73,73,74,73,73,73,73,73,74,74,74,74,74,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,73,73,74,74,74,73,73,73,73,73,73,73,73,73,73,72,72,72,72,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,73,73,72,72,71,70,70,70,69,69,68,68,67,67,66,67,67,68,69,70,71,72,73,73,74,74,73,73,73,74,75,75,74,73,73,74,76,78,75,67,52,32,15,5,8,22,41,59,69,73,72,71,70,71,72,72,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,72,72,72,72,71,71,71,70,70,70,70,70,70,70,69,69,69,69,68,68,68,68,67,67,66,65,65,64,64,64,63,62,61,60,60,60,60,60,61,61,62,62,63,64,65,65,66,67,68,69,70,71,71,71,71,71,71,72,72,73,73,73,72,72,73,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,72,72,72,72,71,71,71,71,71,71,71,72,72,72,72,72,72,72,72,72,71,71,71,72,72,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,72,72,73,73,73,73,73,72,72,72,73,73,74,73,73,73,73,73,73,73,73,73,73,73,73,72,72,72,72,71,71,71,70,70,70,70,69,69,68,67,67,68,69,71,72,73,73,73,73,73,73,73,73,74,75,75,75,74,74,74,75,77,77,75,67,52,34,18,10,12,26,45,62,71,74,73,72,72,72,73,74,74,74,75,75,74,74,74,74,74,74,74,74,74,73,73,73,73,74,74,73,73,73,73,73,73,73,72,72,71,71,71,71,71,70,70,70,69,69,69,68,68,68,68,67,66,65,64,63,63,62,62,62,63,63,63,63,64,65,66,67,69,69,70,71,72,72,73,73,74,74,74,74,75,75,76,76,74,72,70,70,69,69 ]; function drawBkg(canvasElem, squareSize, numSquaresPerBlock, minorLineWidthStr, majorLineWidthStr, lineColStr) { var nLinesDone = 0; var i, curX, curY; var ctx = canvasElem.getContext('2d'); ctx.clearRect(0,0,canvasElem.width,canvasElem.height); // draw the vertical lines curX=0; ctx.strokeStyle = lineColStr; while (curX < canvasElem.width) { if (nLinesDone % numSquaresPerBlock == 0) ctx.lineWidth = majorLineWidthStr; else ctx.lineWidth = minorLineWidthStr; ctx.beginPath(); ctx.moveTo(curX, 0); ctx.lineTo(curX, canvasElem.height); ctx.stroke(); curX += squareSize; nLinesDone++; } // draw the horizontal lines curY=0; nLinesDone = 0; while (curY < canvasElem.height) { if (nLinesDone % numSquaresPerBlock == 0) ctx.lineWidth = majorLineWidthStr; else ctx.lineWidth = minorLineWidthStr; ctx.beginPath(); ctx.moveTo(0, curY); ctx.lineTo(canvasElem.width, curY); ctx.stroke(); curY += squareSize; nLinesDone++; } } // position that will be treated as 0,0 when drawing our points. var originX=49; var originY=72; function drawSamples(nSamplesToDraw, firstSample, lineWidthStr, lineColourStr) { var can = byId('canvas'); var ctx = can.getContext('2d'); ctx.strokeStyle = lineColourStr; ctx.lineWidth = lineWidthStr; console.log(firstSample); ctx.beginPath(); ctx.moveTo( originX+firstSample-1, dataSamples[firstSample-1]+originY ); for (var i=0; i<nSamplesToDraw; i++) { var curSample = dataSamples[i + firstSample]; ctx.lineTo( originX+firstSample+i, curSample+originY ); } ctx.stroke(); } var curFrame=0; var nPointsPerFrame = 4; function drawCurFrame() { if ((dataSamples.length - (nPointsPerFrame * curFrame)) < nPointsPerFrame) // will we over-run the end of the array of datapoints? { curFrame = 0; // if so, reset drawBkg(byId('canvas'), 9.43, 5, "0.5", "1.5", "black"); } drawSamples(nPointsPerFrame, nPointsPerFrame*curFrame, "1", "blue"); curFrame++; requestAnimationFrame( drawCurFrame ); } </script> <style> #canvas { border: solid 1px black; background-color: #FFFFFF; } </style> </head> <body> <div id='txt'></div> <canvas id="canvas" width="1350" height="1300"></canvas> </body> </html>
Update Now that I see you have provided some more info I get what you want. The problem is you need to draw a fixed number of line segments within time t. As you do not know how long each frame could take you can not rely on a fixed frame rate. The alternative it to just use the current time and save the end time. Get the start time and then each frame draw all the should be drawn until the current time. As the line segments being drawn will not be displayed until the next screen refresh the time you get will be approx 16ms behind so will need to adjust for that. What I have done is keep track of the average frame time and used half that time to estimate when the new canvas update will be displayed. Its a bit pedantic but might as well show how to get a required time as close as possible. If you dont care its a few ms out then just remove the average frame time stuff. You will be at most 30ms off on a slow machine. var canvas; // canvas var ctx; function getCanvas () { // to do // get canvas and context } function drawGrid () { // to do // draw the grid } function drawTimedLine(){ if(canvas === undefined){ // if the canvas not available get it getCanvas(); } // clear the canvas is repeating animation ctx.clearRect(0, 0, canvas.width, canvas.height); drawGrid(); var array_1 = ; // your data // All stuff needed for timed animation. // The frame you render will not be displayed untill the next // vertical refresh which is unknown, Assume it is one frame. var startDelay = 1000; // if Needed time in milliseconds to delay start var endTime; // hold the time that the animation has to end var lastDataPoint; // holds the last point drawn to var timeToDraw = 5 * 1000; // how long the animation should last var repeatAfter = 1 *1000; // if you want to repeat the animatoin var frameCount = 0; // count the frames to get average frame time var startTime; //the start time; var numberPoints = array_1.length; // number of points; var startX = 49; // line starts at var yOffset = 72; // line Y offset var endX = 512; // line ends at. var width = endX - startX; // width var xStep = width / numberPoints; // X step per point var pointsPerMS = numberPoints / timeToDraw; // get how many points per ms should be drawn // function to draw function drawWave() { // variable needed var averageframeTime, timeLeft, i, currentTime; currentTime = new Date().valueOf(); // gets the time in millisecond; if (startTime === undefined) { // Is this the first frame startTime = currentTime; // save the start time; endTime = currentTime + timeToDraw; // workout when the end time is; lastDataPoint = 0; // set the data position to the start; averageframeTime = 0; // no frames counted so frame time is zero } else { frameCount += 1; // count the frames // get the average frame time averageframeTime = (currentTime - startTime) / frameCount; } // get the time this frame // will most likely be displayed // then calculate how long // till the end timeLeft = endTime - Math.min(endTime, currentTime + averageframeTime / 2); // now get where we should // be when the frame is presented pointPos = Math.floor(pointsPerMS * (timeToDraw - timeLeft)); // now draw the points from where we last left of // till the new pos; ctx.lineWidth = 4; ctx.strokeStyle = 'blue'; ctx.beginPath(); ctx.moveTo( // move to first point lastDataPoint * xStep + startX, array_1[lastDataPoint] + yOffset ); // draw each line from the last drawn to the new position for (i = lastDataPoint + 1; i <= pointPos && i < numberPoints; i++) { // Add the line segment ctx.lineTo( i * xStep + startX, array_1[i] + yOffset ); } ctx.stroke(); // execute the render commands lastDataPoint = pointPos; // update the last point if (pointPos < numberPoints) { // are we there yet??? requestAnimationFrame(drawWave); // no so request another frame }else{ // if you want to repeat the animation setTimeout(drawTimedLine , repeatAfter ); } } // start the line animation with delay if needed setTimeout(drawWave,startDelay); } // use this if you want it to start as soon as page is ready. document.addEventListener("DOMContentLoaded",drawTimedLine); // or use if you want it to start when page has images loaded and is ready // document.addEventListener("load",drawTimedLine); I have also added the ability to repeat the animation. If not needed just remove that code My original answer Dont know what the problem is with speed as it runs quite well on my machine. To set up a better start use function startFunction(){ // your code } document.addEventListener("DOMContentLoaded",startFunction); This will wait until the page has loaded and parsed the page. Images and other media may not have loaded but the page is ready to be manipulated. Not sure what you mean with 5 seconds. Assuming you may want the thing to sart in 5 seconds. The following will do that. document.addEventListener("DOMContentLoaded",function() {setTimeout(startFunction,5000);}); I would ask why plot the graph one entry at a time with requestAnimationFrame 1250 is not that many lines to draw. If you add ctx.beginPath() ctx.moveTo(/*first point*/) then loop all points with ctx.moveTo(/*points*/) then ctx.stroke() will run realtime on but the slowest of devices. BTW ctx.lineWidth is a Number not a string. Also you have two context? Use the one context for the canvas. Remove ctxt and just use ctx and finally you don't need to add type='text/javascript' to the script tag as Javascript is the default.
1) It cannot take that long to draw 1000 lines, even 100000 lines won't take more than 10 ms on any decent Browser. Look else where the time is lost. 2) The core issue of your code is that it lacks modularity. Split your code into a few clear functions, group the parameters into a few objects only, name and indent things properly. Below an (incomplete but working) example of how this might look. var cv, ctx; var data = null; var debug = true; // --------------------------------------- // define here all graphic related parameters var gfxParams = { canvasWidth: 600, canvasHeight: 600, gridColor: '#A66', gridSpacing: 10, gridLineWidth: 0.5, gridStrongLinesEvery: 5, lineColor: '#AEB', lastLineColor: '#8A9' // , ... }; // define here all animation related parameters var animationParams = { duration: 5, startTime: -1 } // --------------------------------------- // main // --------------------------------------- window.onload = function() { data = getData(); setupCanvas(data); launchAnimation(); } // --------------------------------------- // function setupCanvas(data) { cv = document.getElementById('cv'); cv.width = gfxParams.canvasWidth; cv.height = gfxParams.canvasHeight; ctx = cv.getContext('2d'); // here you should translate and scale the context // so that it shows your data. } function drawGrid(ctx) { var i = 0, pos = 0, lw = gfxParams.gridLineWidth; ctx.fillStyle = gfxParams.gridColor; var vLineCount = gfxParams.canvasWidth / gfxParams.gridSpacing; for (i = 0; i < vLineCount; i++) { pos = i * gfxParams.gridSpacing; ctx.fillRect(pos, 0, lw, gfxParams.canvasHeight); } var hLineCount = gfxParams.canvasHeight / gfxParams.gridSpacing; for (i = 0; i < hLineCount; i++) { pos = i * gfxParams.gridSpacing; ctx.fillRect(0, pos, gfxParams.canvasWidth, lw); } } function animate() { requestAnimationFrame(animate); var now = Date.now(); // erase screen ctx.clearRect(0, 0, gfxParams.canvasWidth, gfxParams.canvasHeight); // draw grid drawGrid(ctx); // draw lines var lastIndex = getLastDrawnIndex(data, now - animationParams.startTime); drawLines(ctx, data, lastIndex); if (debug) { ctx.save(); ctx.fillStyle = '#000'; ctx.fillText(lastIndex + ' lines drawn. Time elapsed : ' + (now - animationParams.startTime), 10, 10); ctx.restore(); } } // comment function launchAnimation() { requestAnimationFrame(animate); animationParams.startTime = Date.now(); } // comment function getData() { var newData = []; for (var i = 0; i < 500; i++) { newData.push([Math.random() * 600, Math.random() * 600]); } return newData; } // comment function getLastDrawnIndex(data, timeElapsed_ms) { var timeElapsed = timeElapsed_ms / 1000; if (timeElapsed >= animationParams.duration) return data.length - 1; return Math.floor(data.length * timeElapsed / animationParams.duration); } function drawLines(ctx, data, lastIndex) { ctx.strokeStyle = gfxParams.lineColor; // other ctx setup here. for (var i = 0; i < lastIndex - 1; i++) { drawLine(ctx, data[i], data[i + 1]); } ctx.strokeStyle = gfxParams.lastLineColor; drawLine(ctx, data[lastIndex - 1], data[lastIndex]); } function drawLine(ctx, p1, p2) { ctx.beginPath(); ctx.moveTo(p1[0], p1[1]); ctx.lineTo(p2[0], p2[1]); ctx.stroke(); } <canvas id='cv'></canvas>
Draw HTML5 Canvas pulse line
Hey guys I've been trying to wrap my head around the HTML5 Canvas animation but failed miserably I wanted to achieve the below figure by animating this custom shape in an interval of 10 seconds. I've pretty much screwed the math of it so I ended up just writing every lineTo statement manually, tried Paul Irish's requestAnimationFrame at the end to animate the line but no luck. Any help would be highly appreciated, here is thelive demo Thanks guys
It's not moving cause you are basically not moving anything - the same shape is drawn to the same position each iteration. Here is a modified version which animates the pulse to the left (adjust dlt to change speed): Modified fiddle here var segX = canvas.width / 6; var segY = canvas.height / 2; function draw() { ctx.clearRect(0,0,canvas.width, canvas.height); ctx.beginPath(); ctx.moveTo(0, segY); for(var i = dlt, h = true; i < canvas.width + segX; i += segX) { if (h) { ctx.lineTo(i, segY); ctx.lineTo(i, segY + segX); } else { ctx.lineTo(i, segY + segX); ctx.lineTo(i, segY); } h = !h; } ctx.stroke(); dlt--; if (dlt < -segX * 2) dlt = 0; requestAnimFrame(draw); }
You're basically needing a function that returns only 2 values--high and low. Here's a function that returns only low/high values based on a period and oscillation values: // squared wave // p = period (how long it takes the wave to fully complete and begin a new cycle) // o = oscillation (change in wave height) function squareY(x) { return( (x%p)<o?o:0 ); } Demo: http://jsfiddle.net/m1erickson/A69ZV/ Example code: <!doctype html> <html> <head> <link rel="stylesheet" type="text/css" media="all" href="css/reset.css" /> <script src="http://code.jquery.com/jquery.min.js"></script> <style> body{ background-color: ivory; } canvas{border:1px solid red;} </style> <script> $(function(){ var canvas=document.getElementById("canvas"); var ctx=canvas.getContext("2d"); ctx.lineWidth=3; var p=30; // period var o=15; // oscillation var fps = 60; var n=0; animate(); function animate() { setTimeout(function() { requestAnimationFrame(animate); // Drawing code goes here n+=1.5; if(n>300){ n=0; } ctx.clearRect(0,0,canvas.width,canvas.height); ctx.beginPath(); for(var x=0;x<n;x++){ var y=squareY(x); ctx.lineTo(x,y+50); } ctx.stroke(); }, 1000 / fps); } // squared sine function squareY(x) { return( (x%p)<o?o:0 ); } }); // end $(function(){}); </script> </head> <body> <canvas id="canvas" width=350 height=350></canvas> </body> </html>
Drawing in canvas becomes slower and slower when it draws more stuff during loop
I am trying to incrementally draw 3 lines which are 120 degrees from each other from a point using html5 canvas. The vertex of each lines will become another 3 new center point and spawns another 3 lines at each center and it repeats this.. My problem is, the incremental speed becomes slower and slower (or the drawing becomes slower) as more items are drawn. (maybe something happens in my code but I am not quite familiar how canvas exactly works...). You can copy the code and run it in your local browser to see what I means. Please see my code (it is very easy to understand) and tell me what causes this. <!DOCTYPE HTML> <html> <head> <style> body { margin: 0px; padding: 0px; } </style> </head> <body> <canvas id="canvas" ></canvas> <script> window.requestAnimFrame = (function(callback) { return window.requestAnimationFrame || window.webkitRequestAnimationFrame || window.mozRequestAnimationFrame || window.oRequestAnimationFrame || window.msRequestAnimationFrame || function(callback) { window.setTimeout(callback, 1000 / 60); }; })(); var canvas=document.getElementById("canvas"); var ctx=canvas.getContext("2d"); canvas.width= window.innerWidth; canvas.height= window.innerHeight; // some staring test values var centerPt={x:canvas.width/2,y:canvas.height/2}; var radius=100; var angle=0; // calculate the 3 endpoints at 120 degree separations var endPt000=anglePoint(centerPt,90); var endPt120=anglePoint(centerPt,210); var endPt240=anglePoint(centerPt,330); var length = 0; var maxLength = 100; var centreSet = new Array(); centreSet = getCentres(); var counter = 0; var end = centreSet.length; init(); function init() { start(centreSet[0].x, centreSet[0].y); } function start(myX, myY) { centerPt.x = myX; centerPt.y = myY; animate(centerPt, length); } function animate(centerPt,length) { // update // clear ctx.clearRect(0, 0, canvas.width, canvas.height); // draw stuff draw(centerPt,length); length = length + 1; // request new frame if(length < maxLength){ requestAnimFrame(function() { animate(centerPt,length); }); } else{ if(counter < end){ counter = counter + 1; centerPt.x = centreSet[counter].x; centerPt.y = centreSet[counter].y; endPt000=anglePoint(centerPt,90); endPt120=anglePoint(centerPt,210); endPt240=anglePoint(centerPt,330); length = 0; setTimeout(function(){animate(centerPt, length);},600); } } } // draw a red center dot // draw 3 blue endpoint dots // draw 3 lines from center going slider% of the way to the endpoints function draw(centerPt,sliderValue){ var pct=sliderValue; ctx.clearRect(0,0,canvas.width,canvas.height); line(centerPt,pointAtPercent(centerPt,endPt000,pct),"green"); line(centerPt,pointAtPercent(centerPt,endPt120,pct),"green"); line(centerPt,pointAtPercent(centerPt,endPt240,pct),"green"); } // calc XY at the specified angle off the centerpoint function anglePoint(centerPt,degrees){ var x=centerPt.x-radius*Math.cos( degrees*Math.PI/180 ); var y=centerPt.y-radius*Math.sin( degrees*Math.PI/180 ); return({x:x,y:y}); } // just draw a line from point1 to point2 function line(pt1,pt2,color){ // ctx.beginPath(); ctx.moveTo(pt1.x,pt1.y); ctx.lineTo(pt2.x,pt2.y); ctx.strokeStyle=color; ctx.lineWidth=2; ctx.stroke(); } // calc XY which is a specified percent distance from pt1 to pt2 function pointAtPercent(pt1,pt2,sliderValue) { // calculate XY at slider% towards pt2 var x = pt1.x + (pt2.x-pt1.x) * sliderValue/100; var y = pt1.y + (pt2.y-pt1.y) * sliderValue/100; return({x:x,y:y}); } //the following are used to get all the center points... function getCentres() { var x = window.innerWidth/2; var y = window.innerHeight/2; centreSet[0] = centerPt; var ref = 0; var end = 0; var b = true; var tempCenter = centerPt; for(var j = 0; j < 5; j++){ tempCenter = centreSet[ref]; end = end + 1; centreSet[end] = anglePoint(tempCenter,90); end = end + 1; centreSet[end] = anglePoint(tempCenter,210); end = end + 1; centreSet[end] = anglePoint(tempCenter,330); ref = ref+1; } return centreSet; } </script> </body> </html>
The problem is you are appending and appending the path. This means that each time you call stroke() the new line together with all the old lines are stroked. You won't see this clearly as the old lines are drawn on top in the same location. And as more and more lines are added the more time it takes to stroke them.. To prevent this you need to break the path. Do this with beginPath(). If you activate your out-commented line it should work fine: function line(pt1,pt2,color){ ctx.beginPath(); //<-- activate this ctx.moveTo(pt1.x,pt1.y); ctx.lineTo(pt2.x,pt2.y); ctx.strokeStyle=color; ctx.lineWidth=2; ctx.stroke(); }
HTML5 canvas continuously stroking lines
I want to draw some continuously growing lines in HTML5 and Javascript. Here is what I want to do: A point located at the center of my screen will have 3 lines growing (120 degree to each other) to a certain length, say 50 pix, then each of this 3 vertex will become a new center and have another 3 lines. (I couldnt post images due to low reputation I have, hopefully you know what I mean abt the image here...) I already written the function to have a array of all the points I need as the centers, starting from the center of my screen. I am thinking to write a loop over this array to draw the lines. I DO NOT want to directly use the stroke so that the line just appears on the screen. I want to have something like the the lines are drawn bit by bit (bad english here, please excuse my english) until it reaches the pre-defined length. However my code dont work quite well here, it only displays all the center points and only the last center point has the movement to have the 3 lines to grow... I need to know the correct way to do this... many thanks in advance! (please ignore the variable time or startTime in my code... ) <script> window.requestAnimFrame = (function(callback) { return window.requestAnimationFrame || window.webkitRequestAnimationFrame || window.mozRequestAnimationFrame || window.oRequestAnimationFrame || window.msRequestAnimationFrame || function(callback) { window.setTimeout(callback, 1000 / 60); }; })(); var canvas = document.getElementById('myCanvas'); canvas.width= window.innerWidth; canvas.height= window.innerHeight; var context = canvas.getContext('2d'); var totalLength = 50; var centreSet = new Array(); var counter = 0; var centre = { x: canvas.width / 2, y: canvas.height / 2, }; var myLine = { length : 0, color : 'grey', lineWidth : 0.5, }; function drawLine(centre, context, mylength) { context.beginPath(); context.moveTo(centre.x, centre.y); context.lineTo(centre.x, centre.y - mylength); context.moveTo(centre.x, centre.y); context.lineTo(centre.x - 0.866 * mylength, centre.y + mylength/2); context.moveTo(centre.x, centre.y); context.lineTo(centre.x + 0.866 * mylength, centre.y + mylength/2); context.lineWidth = myLine.lineWidth; context.strokeStyle = myLine.color; context.closePath(); context.stroke(); } function startAnimate(centre, canvas, context, startTime, mylength) { // update var time = (new Date()).getTime() - startTime; var linearSpeed = 5; // pixels / second var newX = linearSpeed / 10; if(mylength < totalLength) { mylength = mylength + newX; // clear //context.clearRect(0, 0, canvas.width, canvas.height); drawLine(centre, context, mylength); // request new frame requestAnimFrame(function() { startAnimate(centre, canvas, context, startTime, mylength); }); } } function animate(centre, canvas, context, startTime){ //create array to have all the center points centreSet = getCentres(); for (var i = 0; i < centreSet.length; i++){ //pass the x and y values in a object for each center we have in the array centre.x = str2x(centreSet[i]); centre.y = str2y(centreSet[i]); startAnimate(centre, canvas, context, startTime, 0); } } setTimeout(function() { var startTime = (new Date()).getTime(); animate(centre, canvas, context, startTime); }, 1000); I just edited your code, I added the following part: var length = 0; for(var i = 0; i < 380; i++){ window.setTimeout(function() {drawFrame(length);},16.67); length = length + 0.25; } I expect the screen appears to draw the incremental lines bit by bit until it reaches the length I want. However, it seems like the whole incremental process is not shown and it only shows the finished drawing. Can anyone tell me why?
Regarding your followup question about why your animation loop fails By putting your setTimeout in a for-loop, each new setTimeout is cancelling the previous setTimeout. So you’re just left with the very last setTimeout running to completion. In an animation loop, you typically do 3 things during each "frame": Change some data to reflect how the new frame is different from the previous frame. Draw the frame. Test if the animation is complete. If not, do another frame (go to #1). The setTimeout function is used to do the last part of #3 (do another frame) So setTimeout is really acting as your animation loop. --- Your for-loop is not needed. This is how you would restructure your code to follow this pattern: var length=0; var maxLength=50; function draw(){ // make the line .25 longer length=length+.25; // draw drawFrame(length); // test if the line is fully extended // if not, call setTimeout again // setTimeout(draw,100) will call this same draw() function in 100ms if(length<maxLength){ setTimeout(draw,100); } }
[Edited: to include spawning of child objects after lines reach terminal distance] In your code you were not spawning new center points when the lines reached their maximum extension. I would suggest that each of your centre objects have at least this much information in order to spawn a new set of centre objects when their lines reach terminal length: var newCentrePoint={ x:x, y:y, maxLength:newMaxLength, growLength:growLength, currentLength:0, isActive:true } The x,y are the centerpoint’s coordinates. maxLength is the maximum extension of the 3 lines before they are terminated. growLength is the amount by which each line will grow in each new frame. currentLength is the current length of the line. isActive is a flag indicating if this point is growing lines (true) or if it’s terminated (false) Then when each line reaches terminal length you can spawn a new set of lines like this: // spawns 3 new centre points – default values are for testing function spawn(point,newMaxLength,newColor,growLength,newLineWidth){ var max=newMaxLength||point.maxLength/2; var color=newColor|| (colors[++colorIndex%(colors.length)]); var grow=growLength||point.growLength/2; var lw=newLineWidth||point.lineWidth-1; // new center points are spawned at the termination points of the 3 current lines newPoint((point.x),(point.y-point.maxLength),max,color,grow,lw); newPoint((point.x-0.866*point.maxLength),(point.y+point.maxLength/2),max,color,grow,lw); newPoint((point.x+0.866*point.maxLength),(point.y+point.maxLength/2),max,color,grow,lw); } // creates a new point object and puts in the centreSet array for processing function newPoint(x,y,newMaxLength,newColor,growLength,newLineWidth){ var newPt={ x:x, y:y, maxLength:newMaxLength, color:newColor, lineWidth:newLineWidth, growLength:growLength, currentLength:0, isActive:true } centreSet.push(newPt); } Here is code and a Fiddle: http://jsfiddle.net/m1erickson/Vc8Gf/ <!doctype html> <html> <head> <link rel="stylesheet" type="text/css" media="all" href="css/reset.css" /> <!-- reset css --> <script type="text/javascript" src="http://code.jquery.com/jquery.min.js"></script> <style> body{ background-color: ivory; } canvas{border:1px solid red;} </style> <script> $(function(){ var canvas=document.getElementById("canvas"); var context = canvas.getContext('2d'); // colors var colors=["red","blue","gold","purple","green"]; var colorIndex=0; // var centreSet=[] var generations=1; // seed point newPoint(canvas.width/2,canvas.height/2,100,"red",15); // start draw(); // function draw(){ // context.clearRect(0,0,canvas.width,canvas.height); // for(var i=0;i<centreSet.length;i++){ // var centre=centreSet[i]; // if(centre.isActive){ // centre.currentLength+=centre.growLength; // if(centre.currentLength>=centre.maxLength){ centre.isActive=false; centre.currentLength=centre.maxLength; spawn(centre); } } // drawLines(centre); } // if(generations<120){ setTimeout(draw,500); }else{ context.font="18pt Verdana"; context.fillText("Finished 120 generations",40,350); } } function spawn(point,newMaxLength,newColor,growLength,newLineWidth){ var max=newMaxLength||point.maxLength/2; var color=newColor|| (colors[++colorIndex%(colors.length)]); var grow=growLength||point.growLength/2; var lw=newLineWidth||point.lineWidth-1; newPoint((point.x),(point.y-point.maxLength),max,color,grow,lw); newPoint((point.x-0.866*point.maxLength),(point.y+point.maxLength/2),max,color,grow,lw); newPoint((point.x+0.866*point.maxLength),(point.y+point.maxLength/2),max,color,grow,lw); generations++; } function newPoint(x,y,newMaxLength,newColor,growLength,newLineWidth){ var newPt={ x:x, y:y, maxLength:newMaxLength, color:newColor, lineWidth:newLineWidth, growLength:growLength, currentLength:0, isActive:true } centreSet.push(newPt); } function drawLines(centre) { var length=centre.currentLength; // context.beginPath(); context.moveTo(centre.x, centre.y); context.lineTo(centre.x, centre.y - length); // context.moveTo(centre.x, centre.y); context.lineTo(centre.x - 0.866 * length, centre.y + length/2); // context.moveTo(centre.x, centre.y); context.lineTo(centre.x + 0.866 * length, centre.y + length/2); // context.strokeStyle=centre.color; context.lineWidth = centre.lineWidth; context.stroke(); } }); // end $(function(){}); </script> </head> <body> <canvas id="canvas" width=400 height=400></canvas> </body> </html>