how can i make my function more efficient? - javascript
hey guys i wrote a function that compares array values and returns the minimum value but i want to know if there are ways to make it more efficient like iterating through all arrays (using one loop) and putting the results in a new array or making individual arrays sub-arrays of a single array, etc. Also the function provides the correct output but prints the answer three times:
var nums1 = [-7528819, 3927361, -6398192];
var nums2 = [1777100, -2299720, -5566643];
var nums3 = [7188445, 3724971, 7699332];
var nums4 = [-8432528, -159836, -1604959];
var nums5 = [2764889, 4681472, 701396];
var nums6 = [-5073513, 599535, 4388457];
var nums7 = [8689640, 8028586, 1022322];
var nums8 = [-1088592, 1211232, -7868192];
var nums9 = [-5848613, -4945165, 631213];
var nums10 = [3218429, -833619, -1495854];
var nums11 = [8007060, 1637562, -7568493];
var nums12 = [-8391131, -6585338, 131787];
var nums13 = [-3957775, -9396892, -6143241];
var nums14 = [-6258442, -7829421, 3696922];
var nums15 = [2136598, 4935467, -1621605];
var nums16 = [-7162005, 9861954, 8977930];
var nums17 = [7226452, 8551594, 7006517];
var nums18 = [-1751226, -2536997, -1782251];
var nums19 = [380582, 1614389, 3272584];
var nums20 = [-8988205, -5167181, -7561034];
var nums21 = [-484059, -7160121, 4076528];
var nums22 = [1947448, -5551253, 7491190];
var numsLength = nums1.length;
var i = 0;
var minNum;
function test(arr) {
for (i; i < numsLength; i++) {
if (arr[0] < arr[1] && arr[2]) {
minNum = arr[0];
} else if (arr[1] < arr[2] && arr[0]) {
minNum = arr[1];
} else if (arr[2] < arr[1] && arr[0]) {
minNum = arr[2];
}
console.log(minNum);
}
}
test(nums1);
You could just use Math.min function.
console.log(Math.min.apply(null, nums1));
Look at his snippet of code and read inline comments:
var nums = [];
// I'm pushing only 3 sets of data, but there can be any number
// Also there can be any number of elements in each array as you can see
nums.push([-7528819, 3927361, -6398192]);
nums.push([1777100, -2299720, -5566643, 380582]);
nums.push([7188445, 3724971, 7699332, 1947448, -5551253, 7491190]);
function produceResults(nums) {
var i,
results = [];
// gathering results
for (i = 0; i < nums.length; i++) {
results.push(Math.min.apply(null, nums[i]));
}
return results;
}
console.log(produceResults(nums));
So 2 suggestions:
use more dynamic structure (array of arrays) instead of
defining 22 arrays.
use built in JS functions and components (Math.min)
Unrolling a loop is actually the most efficient implementation of a loop in most cases. However, practically speaking, unrolling a loop isn't usually feasible. With a small, fixed-size array, like those you have here, each permutation of the loop is obvious, and if your goal is raw speed you can't get much more efficient than what you have. That being said, the loop in your function is useless, as others have pointed out., because you've essentially unrolled the loop already. Also the syntax of the if statement is incorrect, and you are not handling the case where values in the array are equal. For fixed arrays of size three you want something more along the lines of...
if (val1 <= val2 && val1 <= val3) {
minVal = val1;
} else if (val2 <= val1 && val2 <= val3) {
minVal = val2;
} else minVal = val3;
Now if you want to do an arbitrary search for the min value of any size array you would do something similar, but using a loop, like...
var minVal = null;
for (var i = 0; i < arr.length; i++) {
if (minVal === null || minVal > (val = arr[i]))
minVal = val;
}
Depending on what you actually want to accomplish, and the size of the array, it might make sense to sort the array and rerurn the min (0 index) from the sorted array. If you go that route, start with a google search for "sort algorithms"
Related
Javascript, adding multiple arrays to an array with a for loop
What is the best way to consolidate this code? As it is, it works perfectly, but it needs to go up to maybe 40-50 items long, so it needs to be shortened dramatically, (I assume, with a for loop). I'm pretty much a novice when it comes to Javascript, and trying to add arrays to an array with a loop is confusing me immensely. The "vac1.", "vac2." ...etc, variables are used later on in the code to add pointers onto a Google Maps map. var x = count.count; // x = a value that changes (between 1 & 50) if(x == 1){ locations = [ [vac1.vacancy_title, vac1.vacancy_latlng, vac1.vacancy_url, vac1.vacancy_location] ]; } if(x == 2){ locations = [ [vac1.vacancy_title, vac1.vacancy_latlng, vac1.vacancy_url, vac1.vacancy_location], [vac2.vacancy_title, vac2.vacancy_latlng, vac2.vacancy_url, vac2.vacancy_location] ]; } if(x == 3){ locations = [ [vac1.vacancy_title, vac1.vacancy_latlng, vac1.vacancy_url, vac1.vacancy_location], [vac2.vacancy_title, vac2.vacancy_latlng, vac2.vacancy_url, vac2.vacancy_location], [vac3.vacancy_title, vac3.vacancy_latlng, vac3.vacancy_url, vac3.vacancy_location] ]; } ...etc etc... I have tried using a for loop, but it doesn't work and I have no idea if I am anywhere close to figuring out how to do it correctly. var x = count.count; locations = []; array = []; for (i = 0; i < x; i++) { array = [vac[i].vacancy_title, vac[i].vacancy_latlng, vac[i].vacancy_url, vac[i].vacancy_location]; locations.push(array); } Any help or advice would be greatly appreciated! Thank you.
You need to consider them as a string: var x = 5; locations = []; array = []; for (i = 1; i <= x; i++) { array = ['vac'+i+'.vacancy_title', 'vac'+i+'.vacancy_latlng', 'vac'+i+'.vacancy_url', 'vac'+i+'.vacancy_location']; locations.push(array); } console.log(locations);
Create an array vac and use your previous code : var x = count.count; locations = [], array = [], vac = [ /* vac1, vac2, ...., vacn */ ]; for (i = 0; i < x; i++) { array = [vac[i].vacancy_title, vac[i].vacancy_latlng, vac[i].vacancy_url, vac[i].vacancy_location]; locations.push(array); }
You could use eval for the variable name and build an new array with another array for the wanted keys. Basically you should reorganize yor program to use a solution without eval. An array could help. It is made for iteration. var x = count.count, i, keys = ['vacancy_title', 'vacancy_latlng', 'vacancy_url', 'vacancy_location'], locations = []; object; for (i = 1; i <= x; i++) { object = eval('vac' + i); locations.push(keys.map(function (k) { return object[k]; })); }
Group the vac* elements in an array and then use slice to cut out as many as you want, then use map to generate the result array: var vacs = [vac1, vac2 /*, ...*/]; // group the vacs into one single array var x = count.count; // x is the number of vacs to generate var locations = vacs.slice(0, x).map(function(vac) { // slice (cut out) x elements from the arrays vacs then map the cut-out array into your result array return [vac.vacancy_title, vac.vacancy_latlng, vac.vacancy_url, vac.vacancy_location]; });
Because any global variable is a property of the global object : var vac1 = "whatever"; console.lof(window.vac1); // => logs "whatever" console.lof(window["vac1"]); // => accessed as an array, logs "whatever" too You could use the global object and access it as an array to look for your vac1, vac2, vac3 variables : var x = count.count, i; locations = [], array = [], var globalObject = window; // or whatever the global object is for you var vac; // this will be used to store your vac1, vac2, etc. for (i = 0; i < x; i++) { vac = globalObject["vac"+i]; // the "vac" + i variable read from the global object if (vac !== undefined) { array = [vac.vacancy_title, vac.vacancy_latlng, vac.vacancy_url, vac.vacancy_location]; locations.push(array); } }
Efficiently find every combination of assigning smaller bins to larger bins
Let's say I have 7 small bins, each bin has the following number of marbles in it: var smallBins = [1, 5, 10, 20, 30, 4, 10]; I assign these small bins to 2 large bins, each with the following maximum capacity: var largeBins = [40, 50]; I want to find EVERY combination of how the small bins can be distributed across the big bins without exceeding capacity (eg put small bins #4,#5 in large bin #2, the rest in #1). Constraints: Each small bin must be assigned to a large bin. A large bin can be left empty This problem is easy to solve in O(n^m) O(2^n) time (see below): just try every combination and if capacity is not exceeded, save the solution. I'd like something faster, that can handle a variable number of bins. What obscure graph theory algorithm can I use to reduce the search space? //Brute force var smallBins = [1, 5, 10, 20, 30, 4, 10]; var largeBins = [40, 50]; function getLegitCombos(smallBins, largeBins) { var legitCombos = []; var assignmentArr = new Uint32Array(smallBins.length); var i = smallBins.length-1; while (true) { var isValid = validate(assignmentArr, smallBins, largeBins); if (isValid) legitCombos.push(new Uint32Array(assignmentArr)); var allDone = increment(assignmentArr, largeBins.length,i); if (allDone === true) break; } return legitCombos; } function increment(assignmentArr, max, i) { while (i >= 0) { if (++assignmentArr[i] >= max) { assignmentArr[i] = 0; i--; } else { return i; } } return true; } function validate(assignmentArr, smallBins, largeBins) { var totals = new Uint32Array(largeBins.length); for (var i = 0; i < smallBins.length; i++) { var assignedBin = assignmentArr[i]; totals[assignedBin] += smallBins[i]; if (totals[assignedBin] > largeBins[assignedBin]) { return false; } } return true; } getLegitCombos(smallBins, largeBins);
Here's my cumbersome recursive attempt to avoid duplicates and exit early from too large sums. The function assumes duplicate elements as well as bin sizes are presented grouped and counted in the input. Rather than place each element in each bin, each element is placed in only one of duplicate bins; and each element with duplicates is partitioned distinctly. For example, in my results, the combination, [[[1,10,20]],[[4,5,10,30]]] appears once; while in the SAS example in Leo's answer, twice: once as IN[1]={1,3,4} IN[2]={2,5,6,7} and again as IN[1]={1,4,7} IN[2]={2,3,5,6}. Can't vouch for efficiency or smooth-running, however, as it is hardly tested. Perhaps stacking the calls rather than recursing could weigh lighter on the browser. JavaScript code: function f (as,bs){ // i is the current element index, c its count; // l is the lower-bound index of partitioned element function _f(i,c,l,sums,res){ for (var j=l; j<sums.length; j++){ // find next available duplicate bin to place the element in var k=0; while (sums[j][k] + as[i][0] > bs[j][0]){ k++; } // a place for the element was found if (sums[j][k] !== undefined){ var temp = JSON.stringify(sums), _sums = JSON.parse(temp); _sums[j][k] += as[i][0]; temp = JSON.stringify(res); var _res = JSON.parse(temp); _res[j][k].push(as[i][0]); // all elements were placed if (i == as.length - 1 && c == 1){ result.push(_res); return; // duplicate elements were partitioned, continue to next element } else if (c == 1){ _f(i + 1,as[i + 1][1],0,_sums,_res); // otherwise, continue partitioning the same element with duplicates } else { _f(i,c - 1,j,_sums,_res); } } } } // initiate variables for the recursion var sums = [], res = [] result = []; for (var i=0; i<bs.length; i++){ sums[i] = []; res[i] = []; for (var j=0; j<bs[i][1]; j++){ sums[i][j] = 0; res[i][j] = []; } } _f(0,as[0][1],0,sums,res); return result; } Output: console.log(JSON.stringify(f([[1,1],[4,1],[5,1],[10,2],[20,1],[30,1]], [[40,1],[50,1]]))); /* [[[[1,4,5,10,10]],[[20,30]]],[[[1,4,5,10,20]],[[10,30]]],[[[1,4,5,20]],[[10,10,30]]] ,[[[1,4,5,30]],[[10,10,20]]],[[[1,4,10,20]],[[5,10,30]]],[[[1,4,30]],[[5,10,10,20]]] ,[[[1,5,10,20]],[[4,10,30]]],[[[1,5,30]],[[4,10,10,20]]],[[[1,10,20]],[[4,5,10,30]]] ,[[[1,30]],[[4,5,10,10,20]]],[[[4,5,10,20]],[[1,10,30]]],[[[4,5,30]],[[1,10,10,20]]] ,[[[4,10,20]],[[1,5,10,30]]],[[[4,30]],[[1,5,10,10,20]]],[[[5,10,20]],[[1,4,10,30]]] ,[[[5,30]],[[1,4,10,10,20]]],[[[10,10,20]],[[1,4,5,30]]],[[[10,20]],[[1,4,5,10,30]]] ,[[[10,30]],[[1,4,5,10,20]]],[[[30]],[[1,4,5,10,10,20]]]] */ console.log(JSON.stringify(f([[1,1],[4,1],[5,1],[10,2],[20,1],[30,1]], [[20,2],[50,1]]))); /* [[[[1,4,5,10],[10]],[[20,30]]],[[[1,4,5,10],[20]],[[10,30]]],[[[1,4,5],[20]],[[10,10,30]]] ,[[[1,4,10],[20]],[[5,10,30]]],[[[1,5,10],[20]],[[4,10,30]]],[[[1,10],[20]],[[4,5,10,30]]] ,[[[4,5,10],[20]],[[1,10,30]]],[[[4,10],[20]],[[1,5,10,30]]],[[[5,10],[20]],[[1,4,10,30]]] ,[[[10,10],[20]],[[1,4,5,30]]],[[[10],[20]],[[1,4,5,10,30]]]] */ Here's a second, simpler version that only attempts to terminate the thread when an element cannot be placed: function f (as,bs){ var stack = [], sums = [], res = [] result = []; for (var i=0; i<bs.length; i++){ res[i] = []; sums[i] = 0; } stack.push([0,sums,res]); while (stack[0] !== undefined){ var params = stack.pop(), i = params[0], sums = params[1], res = params[2]; for (var j=0; j<sums.length; j++){ if (sums[j] + as[i] <= bs[j]){ var _sums = sums.slice(); _sums[j] += as[i]; var temp = JSON.stringify(res); var _res = JSON.parse(temp); _res[j].push(i); if (i == as.length - 1){ result.push(_res); } else { stack.push([i + 1,_sums,_res]); } } } } return result; } Output: var r = f([1,5,10,20,30,4,10,3,4,5,1,1,2],[40,50,30]); console.log(r.length) console.log(JSON.stringify(f([1,4,5,10,10,20,30], [40,50]))); 162137 [[[30],[1,4,5,10,10,20]],[[10,30],[1,4,5,10,20]],[[10,20],[1,4,5,10,30]] ,[[10,30],[1,4,5,10,20]],[[10,20],[1,4,5,10,30]],[[10,10,20],[1,4,5,30]] ,[[5,30],[1,4,10,10,20]],[[5,10,20],[1,4,10,30]],[[5,10,20],[1,4,10,30]] ,[[4,30],[1,5,10,10,20]],[[4,10,20],[1,5,10,30]],[[4,10,20],[1,5,10,30]] ,[[4,5,30],[1,10,10,20]],[[4,5,10,20],[1,10,30]],[[4,5,10,20],[1,10,30]] ,[[1,30],[4,5,10,10,20]],[[1,10,20],[4,5,10,30]],[[1,10,20],[4,5,10,30]] ,[[1,5,30],[4,10,10,20]],[[1,5,10,20],[4,10,30]],[[1,5,10,20],[4,10,30]] ,[[1,4,30],[5,10,10,20]],[[1,4,10,20],[5,10,30]],[[1,4,10,20],[5,10,30]] ,[[1,4,5,30],[10,10,20]],[[1,4,5,20],[10,10,30]],[[1,4,5,10,20],[10,30]] ,[[1,4,5,10,20],[10,30]],[[1,4,5,10,10],[20,30]]]
This problem is seen often enough that most Constraint Logic Programming systems include a predicate to model it explicitly. In OPTMODEL and CLP, we call it pack: proc optmodel; set SMALL init 1 .. 7, LARGE init 1 .. 2; num size {SMALL} init [1 5 10 20 30 4 10]; num capacity{LARGE} init [40 50]; var WhichBin {i in SMALL} integer >= 1 <= card(LARGE); var SpaceUsed{i in LARGE} integer >= 0 <= capacity[i]; con pack( WhichBin, size, SpaceUsed ); solve with clp / findall; num soli; set IN{li in LARGE} = {si in SMALL: WhichBin[si].sol[soli] = li}; do soli = 1 .. _nsol_; put IN[*]=; end; quit; This code produces all the solutions in 0.06 seconds on my laptop: IN[1]={1,2,3,4,6} IN[2]={5,7} IN[1]={1,2,3,4} IN[2]={5,6,7} IN[1]={1,2,3,6,7} IN[2]={4,5} IN[1]={1,2,5,6} IN[2]={3,4,7} IN[1]={1,2,5} IN[2]={3,4,6,7} IN[1]={1,2,4,6,7} IN[2]={3,5} IN[1]={1,2,4,7} IN[2]={3,5,6} IN[1]={1,2,4,6} IN[2]={3,5,7} IN[1]={1,3,4,6} IN[2]={2,5,7} IN[1]={1,3,4} IN[2]={2,5,6,7} IN[1]={1,5,6} IN[2]={2,3,4,7} IN[1]={1,5} IN[2]={2,3,4,6,7} IN[1]={1,4,6,7} IN[2]={2,3,5} IN[1]={1,4,7} IN[2]={2,3,5,6} IN[1]={2,3,4,6} IN[2]={1,5,7} IN[1]={2,3,4} IN[2]={1,5,6,7} IN[1]={2,5,6} IN[2]={1,3,4,7} IN[1]={2,5} IN[2]={1,3,4,6,7} IN[1]={2,4,6,7} IN[2]={1,3,5} IN[1]={2,4,7} IN[2]={1,3,5,6} IN[1]={3,5} IN[2]={1,2,4,6,7} IN[1]={3,4,7} IN[2]={1,2,5,6} IN[1]={3,4,6} IN[2]={1,2,5,7} IN[1]={3,4} IN[2]={1,2,5,6,7} IN[1]={5,7} IN[2]={1,2,3,4,6} IN[1]={5,6} IN[2]={1,2,3,4,7} IN[1]={5} IN[2]={1,2,3,4,6,7} IN[1]={4,6,7} IN[2]={1,2,3,5} IN[1]={4,7} IN[2]={1,2,3,5,6} Just change the first 3 lines to solve for other instances. However, as others have pointed out, this problem is NP-Hard. So it can switch from very fast to very slow suddenly. You could also solve the version where not every small item needs to be assigned to a large bin by creating a dummy large bin with enough capacity to fit the entire collection of small items. As you can see from the "Details" section in the manual, the algorithms that solve practical problems quickly are not simple, and their implementation details make a big difference. I am unaware of any CLP libraries written in Javascript. Your best bet may be to wrap CLP in a web service and invoke that service from your Javascript code.
Array text to numbers, find matching values and sort
I have an array which looks like this: ["1,8", "4,6,8", "8,9", "6,9"] 1/ I would like to turn it in to this [1,8,4,6,8,8,9,6,9] 2/ I would then like to find matching values, by looking for the most number: [8] This first has been solved with this: var carArray = ["1,8", "4,6,8,7,7,7,7", "8,9", "6,9"]; //1) create single array var arr = carArray.join().split(','); //2) find most occurring var counts = {}; //object to hold count for each occurence var max = 0, maxOccurring; arr.forEach(function(el){ var cnt = (counts[el] || 0); //previous count counts[el] = ++cnt; if(cnt > max && cnt > 1){ //only register if more than once (cnt>1) max=cnt; maxOccurring = el; } }); if(maxOccurring){ //there was an element more than once, maxOccuring contains that element setResult('Most occuring: ' + maxOccurring + ' (' + max + ' times)'); } else{ //3)/4) ??? setResult('sorting?'); } //below is only for test display purposes function setResult(res){ console.log(res); } 3/ If the are no matching values like this [1,8,4,6,5,7] 4/ Then I need to compare this array to another array, such as this [6,7,4,1,2,8,9,5] If the first number in <4> array above appears in <3> array, then get that number, ie in the above example I need to get 6. The <4> array will be static values and not change. The numbers is <3> will be dynamic. EDIT Not the most elegant of answers, but I do have something working now. I didn't compare the original array directly with the second array, instead used simple if/else statements to do what I needed: var carArray = ["1,5", "4", "8,2", "3,9,1,1,1"]; //1) create single array var arr = carArray.join().split(','); //2) find most occurring var counts = {}; //object to hold count for each occurence var max = 0, maxOccurring; arr.forEach(function(el){ var cnt = (counts[el] || 0); //previous count counts[el] = ++cnt; if(cnt > max && cnt > 1){ //only register if more than once (cnt>1) max=cnt; maxOccurring = el; } }); if(maxOccurring){ //there was an element more than once, maxOccuring contains that element console.log('Most occuring: ' + maxOccurring + ' (' + max + ' times)'); console.log(maxOccurring); } else { // If not occuring, match from a list if(jQuery.inArray("6", arr) !== -1) { console.log('6'); } else if(jQuery.inArray("9", arr) !== -1) { console.log('9'); } else if(jQuery.inArray("7", arr) !== -1) { console.log('7'); } else if(jQuery.inArray("5", arr) !== -1) { console.log('5'); } else if(jQuery.inArray("4", arr) !== -1) { console.log('4'); } else if(jQuery.inArray("1", arr) !== -1) { console.log('1'); } else { console.log('not found'); } }
Example Fiddle Step 1 is fairly easy by using javascript's join and split methods respectively: var arr = carArray .join().split(','); For step 2, several methods can be used, the most common one using an object and using the elements themselves as properties. Since you only need to get the most occurring value if there is a reoccurring value, it can be used in the same loop: var counts = {}; //object to hold count for each occurence var max = 0, maxOccurring; arr.forEach(function(el){ var cnt = (counts[el] || 0); //previous count counts[el] = ++cnt; if(cnt > max && cnt > 1){ //only register if more than once (cnt>1) max=cnt; maxOccurring = el; } }); After the above, the variable maxOccurring will contain the reoccurring value (if any) and max will contain the times it occured For step 4 the easiest way is to loop through the compare array and get the element that occurs in the input array: var cmpArr = ['6','7','4','1','2','8','9','5']; //find the first occurrence inside the cmpArr res = function(){ for(var i= 0 ; i < cmpArr.length; i++){ if(arr.indexOf(cmpArr[i]) !== -1)return cmpArr[i];}}(); The above uses an in place function which is called immediately to be able to use return. You could also just use a loop and assign res when found, then break from the loop. Last update, an alternate fiddle where the above is converted to a single function: http://jsfiddle.net/v9hhsdny/5/
Well first of all the following code results in four matching answers since the jQuery selectors are the same. var questionAnswer1 = $(this).find('input[name=questionText]').val(); var questionAnswer2 = $(this).find('input[name=questionText]').val(); var questionAnswer3 = $(this).find('input[name=questionText]').val(); var questionAnswer4 = $(this).find('input[name=questionText]').val(); var carArray = [questionAnswer1, questionAnswer2, questionAnswer3, questionAnswer4]; You could use the eq(index) method of jQuery to select the appropriate element. However having 4 inputs with the same name is a bad practice. Well lets say that the carArray has 4 different values which all consist out of comma separated numbers. You could then do the following: var newArr = []; carArray.forEach(function(e) { e.split(",").forEach(function(n) { newArr.push(n); }); }); Well then we got to find the most occurring number. JavaScript doesn't have any functions for that so we will have to find an algorithm for that. I found the following algorithm on this stackoverflow page var count = function(ary, classifier) { return ary.reduce(function(counter, item) { var p = (classifier || String)(item); counter[p] = counter.hasOwnProperty(p) ? counter[p] + 1 : 1; return counter; }, {}) } var occurances = count(newArr);
It isn't clear to me what you're trying to do in step 3 and 4, so can't answer those at the moment. var ary = ["1,8", "4,6,8", "8,9", "6,9"]; var splitted = ary.reduce(function(acc, item) { return acc.concat(item.split(',')); }, []); var occurences = splitted.reduce(function(acc, item) { if (!acc.hasOwnProperty(item)) acc[item] = 0; acc[item] += 1; return acc; },{}), biggest = Object.keys(occurences).reduce(function (acc, key) { if (occurences[key] > acc.occurences) { acc.name = key; acc.occurences = occurences[key]; } return acc; },{'name':'none','occurences':0}).name;
var vals=["1,8", "4,6,8", "8,9", "6,9"]; // 1) turn into number array var arrNew=[]; for(var i=0; i<vals.length; i++) { arrLine=vals[i].split(","); for (var j=0;j<arrLine.length;j++) { arrNew.push (parseInt(arrLine[j])) } } //result: alert(arrNew.join(";"); // 2) find most common var found=[]; for(var i=0; i<arrNew.length; i++) { // make an array of the number of occurrances of each value if (found["num"+newArray[i]]) { found["num"+newArray[i]] ++ ; } else { found["num"+newArray[i]]=1; } } var mostCommon={count:0,val:"ROGUE"}; for (x in found) { if (found[x] > mostCommon.count) { mostCommon.count=found[x].count; mostCommon.val=x; } } // result : alert(mostCommon.val); //3) not quite sure what you meant there // 4) unique values: // at this point the 'found' list contains unique vals var arrUnique=[]; for (x in found) { arrUnique.push[x]; } // result : alert(arrUnique.join(";")) //sort: arrUnique.sort(function(a, b){return a-b});
(This won't work in most browsers) but on a side note, when ES6 becomes widely supported, your solution could look like this: var arr1 = ["1,8", "4,6,8", "8,9", "6,9"]; var arr2 = arr1.join().split(','); var s = Array.from(new Set(arr2)); //Array populated by unique values, ["1", "8", "4", "6", "9"] Thought you might like to see a glimpse of the future!
1. var orgArray = ['1,8', '4,6,8', '8,9', '6,9']; var newArray = []; for (var i in orgArray) { var tmpArray = orgArray[i].split(','); for (var j in tmpArray) { newArray.push(Number(tmpArray[j])); } } 2. var counts = {}; var most = null; for (var i in newArray) { var num = newArray[i]; if (typeof counts[num] === 'undefined') { counts[num] = 1; } else { ++(counts[num]); } if (most == null || counts[num] > counts[most]) { most = num; } else if (most != null && counts[num] === counts[most]) { most = null; } } I don't understand the question 3 and 4 (what "unique order" means) so I can't answer those questions.
Javascript undefined array in function
I've written a function that takes plevel (integer) and slevel (array of strings of numbers) and finds the smallest difference between plevel and a value in slevel. However, when I run the script, it is unresponsive and the debugger says that diff is undefined. var findDiff = function findDiff(plevel, slevel) { var diff = new Array(); for (i=0; i<=slevel.length; i++) { sleveli = parseInt(slevel[i]); diff.push(Math.abs(plevel-sleveli)); } if (diff.length > 1){ diff.sort(function(a, b){return a-b}); return diff[0] } else{ return diff[0]; } } The function is invoked here: var matches = new Array(); var newFetch = Data.find().fetch(); for(i = 0; i <= newFetch.length; i++ ){ pointsMatch = 0 var difference = findDiff(newFetch[i].level, spec.level); pointsMatch -= (difference*3); matches.push([newFetch[i], pointsMatch]) } console.log(matches) Data is a mongoDB collection. spec.level is an array of strings of numbers stored as a property in an object.
I would like to point out name space pollution, which may cause serious troubles. In my understanding, you have two cases of namespace pollution, one of it creates an endless loop. You have actually an inner an outer loop, separated by a function. Your outer for loop: for(i = 0; i <= newFetch.length; i++ ){ pointsMatch = 0 ... And then your inner for loop: for (i=0; i<=slevel.length; i++) { sleveli = parseInt(slevel[i]); ... Because of the missing var before i, both for loop definitions are actually like this: for (window.i=0; ... So the inner loop overwrites the variable i the outer loop depends on to terminate. i is "polluting" namespace. The second case is harmless: sleveli = parseInt(slevel[i]); Because of the missing var, this results in fact in window.sleveli = parseInt(slevel[i]); Better would be var sleveli = parseInt(slevel[i]); But this is a time bomb. I suggest you add var to the definitions of i in the for loop.
I think the people in the comments are right; we need to see some more of your input to debug this properly. But you can simplify your code a lot by tracking the mins as you go: var findDiff = function findDiff(plevel, slevel) { var min = Number.MAX_SAFE_INTEGER; for (i=0; i<slevel.length; i++) { sleveli = parseInt(slevel[i]); var diff = Math.abs(plevel-sleveli); min = Math.min(min, diff) } return min; } var a = ["1", "2", "10", "17"] var p = 6 // We're expecting 4 as the min diff console.log(findDiff(p, a)) // ...prints out 4 :-) http://repl.it/ceX As Omri points out, use < not <= in your for loop. Note - Number is not always available -- see here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER You could alternatively set the initial min to something suitably large for your likely data, like 2^10
How to count the array from specific JSON object value?
here is my javascript: var json = '{"GetReportIdResult":[{"bulan":"4","total":"1728","type":"CHEESE1K","uang":"8796383"},{"bulan":"4","total":"572476","type":"ESL","uang":"5863408410"},{"bulan":"4","total":"33507","type":"WHP","uang":"235653242"},{"bulan":"5","total":"4761","type":"CHEESE1K","uang":"134877865"},{"bulan":"5","total":"245867","type":"UHT","uang":"1446787280"},{"bulan":"5","total":"47974","type":"WHP","uang":"631929807"},{"bulan":"6","total":"5762","type":"CHEESE1K","uang":"293393832"},{"bulan":"6","total":"236803","type":"UHT","uang":"2219506085"},{"bulan":"6","total":"24853","type":"WHP","uang":"386175022"}]}'; obj = JSON.parse(json); var arrayobj = obj.GetReportIdResult.length; alert (arrayobj); I want to count how many type in the same bulan value, (e.g. there are 3 type = CHEESE1K, UHT, and ESL in bulan = 4) how to do that?
There's still a typo in your JSON: you've got two commas in a row between the first two "bulan":"6" objects. But assuming you fix that... If you're asking how to count distinct types for a particular bulan value you can do something like this: function countTypesForBulan(resultArray, bulanVal) { var i, types, count = 0; for (i=0, types = {}; i < resultArray.length; i++) if (resultArray[i].bulan === bulanVal && !types[resultArray[i].type]) { types[resultArray[i].type] = true; count++; } return count; } console.log( countTypesForBulan(obj.GetReportIdResult, "4") ); // logs 3 The above loops through the array looking for a particular bulan value, and when it finds one it checks if it has already seen the associated type - if not, it adds it to the types object and increments the counter. Demo: http://jsfiddle.net/pAWrT/
First of all, put the JSON into a string, else your example code wont work. var json = '{"GetReportIdResult":[{"bulan":"4","total":"1728","type":"CHEESE1K","uang":"8796383"},{"bulan":"4","total":"572476","type":"ESL","uang":"5863408410"},{"bulan":"4","total":"33507","type":"WHP","uang":"235653242"},{"bulan":"5","total":"4761","type":"CHEESE1K","uang":"134877865"},{"bulan":"5","total":"245867","type":"UHT","uang":"1446787280"},{"bulan":"5","total":"47974","type":"WHP","uang":"631929807"},{"bulan":"6","total":"5762","type":"CHEESE1K","uang":"293393832"},,{"bulan":"6","total":"236803","type":"UHT","uang":"2219506085"},{"bulan":"6","total":"24853","type":"WHP","uang":"386175022"}]}'; Then, Iterate with for and count in a variable or a hashmap. Since GetReportIdResult is an array, you can: for( var i : obj.GetReportIdResult ){ obj.GetReportIdResult[i] ... // Use at will.
This will give you a map object which will contain the count for each bulan value. For example, map['4'].count will return 3. var i, row, arr = obj.GetReportIdResult, map = {}; for (i = 0; i < arr.length; i++) { row = arr[i]; map[row.bulan] = map[row.bulan] || {count: 0}; if (map[row.bulan][row.type] === undefined) { map[row.bulan][row.type] = row.type; map[row.bulan]['count'] += 1; } } console.log (JSON.stringify(map)); JSFiddle here.