Efficiently find every combination of assigning smaller bins to larger bins - javascript
Let's say I have 7 small bins, each bin has the following number of marbles in it:
var smallBins = [1, 5, 10, 20, 30, 4, 10];
I assign these small bins to 2 large bins, each with the following maximum capacity:
var largeBins = [40, 50];
I want to find EVERY combination of how the small bins can be distributed across the big bins without exceeding capacity (eg put small bins #4,#5 in large bin #2, the rest in #1).
Constraints:
Each small bin must be assigned to a large bin.
A large bin can be left empty
This problem is easy to solve in O(n^m) O(2^n) time (see below): just try every combination and if capacity is not exceeded, save the solution. I'd like something faster, that can handle a variable number of bins. What obscure graph theory algorithm can I use to reduce the search space?
//Brute force
var smallBins = [1, 5, 10, 20, 30, 4, 10];
var largeBins = [40, 50];
function getLegitCombos(smallBins, largeBins) {
var legitCombos = [];
var assignmentArr = new Uint32Array(smallBins.length);
var i = smallBins.length-1;
while (true) {
var isValid = validate(assignmentArr, smallBins, largeBins);
if (isValid) legitCombos.push(new Uint32Array(assignmentArr));
var allDone = increment(assignmentArr, largeBins.length,i);
if (allDone === true) break;
}
return legitCombos;
}
function increment(assignmentArr, max, i) {
while (i >= 0) {
if (++assignmentArr[i] >= max) {
assignmentArr[i] = 0;
i--;
} else {
return i;
}
}
return true;
}
function validate(assignmentArr, smallBins, largeBins) {
var totals = new Uint32Array(largeBins.length);
for (var i = 0; i < smallBins.length; i++) {
var assignedBin = assignmentArr[i];
totals[assignedBin] += smallBins[i];
if (totals[assignedBin] > largeBins[assignedBin]) {
return false;
}
}
return true;
}
getLegitCombos(smallBins, largeBins);
Here's my cumbersome recursive attempt to avoid duplicates and exit early from too large sums. The function assumes duplicate elements as well as bin sizes are presented grouped and counted in the input. Rather than place each element in each bin, each element is placed in only one of duplicate bins; and each element with duplicates is partitioned distinctly.
For example, in my results, the combination, [[[1,10,20]],[[4,5,10,30]]] appears once; while in the SAS example in Leo's answer, twice: once as IN[1]={1,3,4} IN[2]={2,5,6,7} and again as IN[1]={1,4,7} IN[2]={2,3,5,6}.
Can't vouch for efficiency or smooth-running, however, as it is hardly tested. Perhaps stacking the calls rather than recursing could weigh lighter on the browser.
JavaScript code:
function f (as,bs){
// i is the current element index, c its count;
// l is the lower-bound index of partitioned element
function _f(i,c,l,sums,res){
for (var j=l; j<sums.length; j++){
// find next available duplicate bin to place the element in
var k=0;
while (sums[j][k] + as[i][0] > bs[j][0]){
k++;
}
// a place for the element was found
if (sums[j][k] !== undefined){
var temp = JSON.stringify(sums),
_sums = JSON.parse(temp);
_sums[j][k] += as[i][0];
temp = JSON.stringify(res);
var _res = JSON.parse(temp);
_res[j][k].push(as[i][0]);
// all elements were placed
if (i == as.length - 1 && c == 1){
result.push(_res);
return;
// duplicate elements were partitioned, continue to next element
} else if (c == 1){
_f(i + 1,as[i + 1][1],0,_sums,_res);
// otherwise, continue partitioning the same element with duplicates
} else {
_f(i,c - 1,j,_sums,_res);
}
}
}
}
// initiate variables for the recursion
var sums = [],
res = []
result = [];
for (var i=0; i<bs.length; i++){
sums[i] = [];
res[i] = [];
for (var j=0; j<bs[i][1]; j++){
sums[i][j] = 0;
res[i][j] = [];
}
}
_f(0,as[0][1],0,sums,res);
return result;
}
Output:
console.log(JSON.stringify(f([[1,1],[4,1],[5,1],[10,2],[20,1],[30,1]], [[40,1],[50,1]])));
/*
[[[[1,4,5,10,10]],[[20,30]]],[[[1,4,5,10,20]],[[10,30]]],[[[1,4,5,20]],[[10,10,30]]]
,[[[1,4,5,30]],[[10,10,20]]],[[[1,4,10,20]],[[5,10,30]]],[[[1,4,30]],[[5,10,10,20]]]
,[[[1,5,10,20]],[[4,10,30]]],[[[1,5,30]],[[4,10,10,20]]],[[[1,10,20]],[[4,5,10,30]]]
,[[[1,30]],[[4,5,10,10,20]]],[[[4,5,10,20]],[[1,10,30]]],[[[4,5,30]],[[1,10,10,20]]]
,[[[4,10,20]],[[1,5,10,30]]],[[[4,30]],[[1,5,10,10,20]]],[[[5,10,20]],[[1,4,10,30]]]
,[[[5,30]],[[1,4,10,10,20]]],[[[10,10,20]],[[1,4,5,30]]],[[[10,20]],[[1,4,5,10,30]]]
,[[[10,30]],[[1,4,5,10,20]]],[[[30]],[[1,4,5,10,10,20]]]]
*/
console.log(JSON.stringify(f([[1,1],[4,1],[5,1],[10,2],[20,1],[30,1]], [[20,2],[50,1]])));
/*
[[[[1,4,5,10],[10]],[[20,30]]],[[[1,4,5,10],[20]],[[10,30]]],[[[1,4,5],[20]],[[10,10,30]]]
,[[[1,4,10],[20]],[[5,10,30]]],[[[1,5,10],[20]],[[4,10,30]]],[[[1,10],[20]],[[4,5,10,30]]]
,[[[4,5,10],[20]],[[1,10,30]]],[[[4,10],[20]],[[1,5,10,30]]],[[[5,10],[20]],[[1,4,10,30]]]
,[[[10,10],[20]],[[1,4,5,30]]],[[[10],[20]],[[1,4,5,10,30]]]]
*/
Here's a second, simpler version that only attempts to terminate the thread when an element cannot be placed:
function f (as,bs){
var stack = [],
sums = [],
res = []
result = [];
for (var i=0; i<bs.length; i++){
res[i] = [];
sums[i] = 0;
}
stack.push([0,sums,res]);
while (stack[0] !== undefined){
var params = stack.pop(),
i = params[0],
sums = params[1],
res = params[2];
for (var j=0; j<sums.length; j++){
if (sums[j] + as[i] <= bs[j]){
var _sums = sums.slice();
_sums[j] += as[i];
var temp = JSON.stringify(res);
var _res = JSON.parse(temp);
_res[j].push(i);
if (i == as.length - 1){
result.push(_res);
} else {
stack.push([i + 1,_sums,_res]);
}
}
}
}
return result;
}
Output:
var r = f([1,5,10,20,30,4,10,3,4,5,1,1,2],[40,50,30]);
console.log(r.length)
console.log(JSON.stringify(f([1,4,5,10,10,20,30], [40,50])));
162137
[[[30],[1,4,5,10,10,20]],[[10,30],[1,4,5,10,20]],[[10,20],[1,4,5,10,30]]
,[[10,30],[1,4,5,10,20]],[[10,20],[1,4,5,10,30]],[[10,10,20],[1,4,5,30]]
,[[5,30],[1,4,10,10,20]],[[5,10,20],[1,4,10,30]],[[5,10,20],[1,4,10,30]]
,[[4,30],[1,5,10,10,20]],[[4,10,20],[1,5,10,30]],[[4,10,20],[1,5,10,30]]
,[[4,5,30],[1,10,10,20]],[[4,5,10,20],[1,10,30]],[[4,5,10,20],[1,10,30]]
,[[1,30],[4,5,10,10,20]],[[1,10,20],[4,5,10,30]],[[1,10,20],[4,5,10,30]]
,[[1,5,30],[4,10,10,20]],[[1,5,10,20],[4,10,30]],[[1,5,10,20],[4,10,30]]
,[[1,4,30],[5,10,10,20]],[[1,4,10,20],[5,10,30]],[[1,4,10,20],[5,10,30]]
,[[1,4,5,30],[10,10,20]],[[1,4,5,20],[10,10,30]],[[1,4,5,10,20],[10,30]]
,[[1,4,5,10,20],[10,30]],[[1,4,5,10,10],[20,30]]]
This problem is seen often enough that most Constraint Logic Programming systems include a predicate to model it explicitly. In OPTMODEL and CLP, we call it pack:
proc optmodel;
set SMALL init 1 .. 7, LARGE init 1 .. 2;
num size {SMALL} init [1 5 10 20 30 4 10];
num capacity{LARGE} init [40 50];
var WhichBin {i in SMALL} integer >= 1 <= card(LARGE);
var SpaceUsed{i in LARGE} integer >= 0 <= capacity[i];
con pack( WhichBin, size, SpaceUsed );
solve with clp / findall;
num soli;
set IN{li in LARGE} = {si in SMALL: WhichBin[si].sol[soli] = li};
do soli = 1 .. _nsol_;
put IN[*]=;
end;
quit;
This code produces all the solutions in 0.06 seconds on my laptop:
IN[1]={1,2,3,4,6} IN[2]={5,7}
IN[1]={1,2,3,4} IN[2]={5,6,7}
IN[1]={1,2,3,6,7} IN[2]={4,5}
IN[1]={1,2,5,6} IN[2]={3,4,7}
IN[1]={1,2,5} IN[2]={3,4,6,7}
IN[1]={1,2,4,6,7} IN[2]={3,5}
IN[1]={1,2,4,7} IN[2]={3,5,6}
IN[1]={1,2,4,6} IN[2]={3,5,7}
IN[1]={1,3,4,6} IN[2]={2,5,7}
IN[1]={1,3,4} IN[2]={2,5,6,7}
IN[1]={1,5,6} IN[2]={2,3,4,7}
IN[1]={1,5} IN[2]={2,3,4,6,7}
IN[1]={1,4,6,7} IN[2]={2,3,5}
IN[1]={1,4,7} IN[2]={2,3,5,6}
IN[1]={2,3,4,6} IN[2]={1,5,7}
IN[1]={2,3,4} IN[2]={1,5,6,7}
IN[1]={2,5,6} IN[2]={1,3,4,7}
IN[1]={2,5} IN[2]={1,3,4,6,7}
IN[1]={2,4,6,7} IN[2]={1,3,5}
IN[1]={2,4,7} IN[2]={1,3,5,6}
IN[1]={3,5} IN[2]={1,2,4,6,7}
IN[1]={3,4,7} IN[2]={1,2,5,6}
IN[1]={3,4,6} IN[2]={1,2,5,7}
IN[1]={3,4} IN[2]={1,2,5,6,7}
IN[1]={5,7} IN[2]={1,2,3,4,6}
IN[1]={5,6} IN[2]={1,2,3,4,7}
IN[1]={5} IN[2]={1,2,3,4,6,7}
IN[1]={4,6,7} IN[2]={1,2,3,5}
IN[1]={4,7} IN[2]={1,2,3,5,6}
Just change the first 3 lines to solve for other instances. However, as others have pointed out, this problem is NP-Hard. So it can switch from very fast to very slow suddenly. You could also solve the version where not every small item needs to be assigned to a large bin by creating a dummy large bin with enough capacity to fit the entire collection of small items.
As you can see from the "Details" section in the manual, the algorithms that solve practical problems quickly are not simple, and their implementation details make a big difference. I am unaware of any CLP libraries written in Javascript. Your best bet may be to wrap CLP in a web service and invoke that service from your Javascript code.
Related
Minimum number of swaps to sort an array
I need to do something like this: Let's say I have an array: [3, 4, 1, 2] I need to swap 3 and 4, and 1 and 2, so my array looks like [4, 3, 2, 1]. Now, I can just do the sort(). Here I need to count how many iterations I need, to change the initial array to the final output. Example: // I can sort one pair per iteration let array = [3, 4, 1, 2, 5] let counter = 0; //swap 3 and 4 counter++; // swap 1 and 2 counter++; // 5 goes to first place counter++ // now counter = 3 <-- what I need EDIT: Here is what I tried. doesn't work always tho... it is from this question: Bubble sort algorithm JavaScript let counter = 0; let swapped; do { swapped = false; for (var i = 0; i < array.length - 1; i++) { if (array[i] < array[i + 1]) { const temp = array[i]; array[i] = array[i + 1]; array[i + 1] = temp; swapped = true; counter++; } } } while (swapped); EDIT: It is not correct all the time because I can swap places from last to first, for example. Look at the example code above, it is edited now.
This is most optimal code I have tried so far, also the code is accepted as optimal answer by hackerrank : function minimumSwaps(arr) { var arrLength = arr.length; // create two new Arrays // one record value and key separately // second to keep visited node count (default set false to all) var newArr = []; var newArrVisited = []; for (let i = 0; i < arrLength; i++) { newArr[i]= []; newArr[i].value = arr[i]; newArr[i].key = i; newArrVisited[i] = false; } // sort new array by value newArr.sort(function (a, b) { return a.value - b.value; }) var swp = 0; for (let i = 0; i < arrLength; i++) { // check if already visited or swapped if (newArr[i].key == i || newArrVisited[i]) { continue; } var cycle = 0; var j = i; while (!newArrVisited[j]) { // mark as visited newArrVisited[j] = true; j = newArr[j].key; //assign next key cycle++; } if (cycle > 0) { swp += (cycle > 1) ? cycle - 1 : cycle; } } return swp; } reference
//You are given an unordered array consisting of consecutive integers [1, 2, 3, ..., n] without any duplicates. //still not the best function minimumSwaps(arr) { let count = 0; for(let i =0; i< arr.length; i++){ if(arr[i]!=i+1){ let temp = arr[i]; arr[arr.indexOf(i+1)] =temp; arr[i] = i+1; count =count+1; } } return count; }
I assume there are two reasons you're wanting to measure how many iterations a sort takes. So I will supply you with some theory (if the mathematics is too dense, don't worry about it), then some practical application. There are many sort algorithms, some of them have a predicable number of iterations based on the number of items you are sorting, some of them are luck of the draw simply based on the order of the items to be sorted and which item how you select what is called a pivot. So if optimisation is very important to you, then you'll want to select the right algorithm for the purpose of the sort algorithm. Otherwise go for a general purpose algorithm. Here are most popular sorting algorithms for the purpose of learning, and each of them have least, worst and average running-cases. Heapsort, Radix and binary-sort are worth looking at if this is more than just an theoretical/learning exercise. Quicksort Worst Case: Θ(n 2) Best case: Θ(n lg n) Average case: Θ(n lg n) Here is a Quicksort implementation by Charles Stover Merge sort Worst case: Θ(n lg n) Best case: Θ(n lg n) Average Case: Θ(n lg n) (note they're all the same) Here is a merge sort implementation by Alex Kondov Insertion sort Worst case: Θ(n2) Best case: Θ(n) Average case:Θ(n2) (Note that its worst and average case are the same, but its best case is the best of any algorithm) Here is an insertion sort implementation by Kyle Jensen Selection sort Worst case: Θ(n2) Best case: Θ(n2) Average case: Θ(n2) (note they're all the same, like a merge sort). Here is a selection sort algorithm written by #dbdavid updated by myself for ES6 You can quite easily add an iterator variable to any of these examples to count the number of swaps they make, and play around with them to see which algorithms work best in which circumstance. If there's a very good chance the items will already be well sorted, insertion sort is your best choice. If you have absolutely no idea, of the four basic sorting algorithms quicksort is your best choice.
function minimumSwaps(arr) { var counter = 0; for (var i = arr.length; i > 0; i--) { var minval = Math.min(...arr); console.log("before", arr); var minIndex = arr.indexOf(minval); if (minval != = arr[0]) { var temp = arr[0]; arr[0] = arr[minIndex]; arr[minIndex] = temp; console.log("after", arr); arr.splice(0, 1); counter++; } else { arr.splice(0, 1); console.log("in else case") } } return counter; } This is how I call my swap function: minimumSwaps([3, 7, 6, 9, 1, 8, 4, 10, 2, 5]); It works with Selection Sort. Logic is as follows: Loop through the array length Find the minimum element in the array and then swap with the First element in the array, if the 0th Index doesn't have the minimum value founded out. Now remove the first element. If step 2 is not present, remove the first element(which is the minimum value present already) increase counter when we swap the values. Return the counter value after the for Loop. It works for all values. However, it fails due to a timeout for values around 50,000.
The solution to this problem is not very intuitive unless you are already somewhat familiar with computer science or real math wiz, but it all comes down to the number of inversions and the resulting cycles If you are new to computer science I recommend the following resources to supplement this solution: GeeksforGeeks Article Informal Proof Explanation Graph Theory Explanation If we define an inversion as: arr[i]>arr[j] where "i" is the current index and "j" is the following index -- if there are no inversions the array is already in order and requires no sorting. For Example: [1,2,3,4,5] So the number of swaps is related to the number of inversions, but not directly because each inversion can lead to a series of swaps (as opposed to a singular swap EX: [3,1,2]). So if one consider's the following array: [4,5,2,1,3,6,10,9,7,8] This array is composed of three cycles. Cycle One- 4,1,3 (Two Swaps) Cycle Two- 5,2 (One Swap) Cycle Three- 6 (0 Swaps) Cycle Four- 10,9,7,8 (3 Swaps) Now here's where the CS and Math magic really kicks in: each cycle will only require one pass through to properly sort it, and this is always going to be true. So another way to say this would be-- the minimum number of swaps to sort any cycle is the number of element in that cycle minus one, or more explicitly: minimum swaps = (cycle length - 1) So if we sum the minimum swaps from each cycle, that sum will equal the minimum number of swaps for the original array. Here is my attempt to explain WHY this algorithm works: If we consider that any sequential set of numbers is just a section of a number line, then any set starting at zero should be equal to its own index should the set be expressed as a Javascript array. This idea becomes the criteria to programmatically determined if in element is already in the correct position based on its own value. If the current value is not equal to its own index then the program should detect a cycle start and recording its length. Once the while loop reaches the the original value in the cycle it will add the minimum number of swaps in the cycle to a counter variable. Anyway here is my code-- it is very verbose but should work: export const minimumSwaps = (arr) => { //This function returns the lowest value //from the provided array. //If one subtracts this value the from //any value in the array it should equal //that value's index. const shift = (function findLowest(arr){ let lowest=arr[0]; arr.forEach((val,i)=>{ if(val<lowest){ lowest=val; } }) return lowest; })(arr); //Declare a counter variable //to keep track of the swaps. let swaps = 0; //This function returns an array equal //in size to the original array provided. //However, this array is composed of //boolean values with a value of false. const visited = (function boolArray(n){ const arr=[]; for(let i = 0; i<n;i++){ arr.push(false); } return arr; })(arr.length); //Iterate through each element of the //of the provided array. arr.forEach((val, i) => { //If the current value being assessed minus //the lowest value in the original array //is not equal to the current loop index, //or, if the corresponding index in //the visited array is equal to true, //then the value is already sorted if (val - shift === i || visited[i]) return; //Declare a counter variable to record //cycle length. let cycleLength = 0; //Declare a variable for to use for the //while loop below, one should start with //the current loop index let x = i; //While the corresponding value in the //corresponding index in the visited array //is equal to false, then we while (!visited[x]) { //Set the value of the current //corresponding index to true visited[x] = true; //Reset the x iteration variable to //the next potential value in the cycle x = arr[x] - shift; //Add one to the cycle length variable cycleLength++; }; //Add the minimum number of swaps to //the swaps counter variable, which //is equal to the cycle length minus one swaps += cycleLength - 1; }); return swaps }
This solution is simple and fast. function minimumSwaps(arr) { let minSwaps = 0; for (let i = 0; i < arr.length; i++) { // at this position what is the right number to be here // for example at position 0 should be 1 // add 1 to i if array starts with 1 (1->n) const right = i+1; // is current position does not have the right number if (arr[i] !== right) { // find the index of the right number in the array // only look from the current position up passing i to indexOf const rightIdx = arr.indexOf(right, i); // replace the other position with this position value arr[rightIdx] = arr[i]; // replace this position with the right number arr[i] = right; // increment the swap count since a swap was done ++minSwaps; } } return minSwaps; }
Here is my solution, but it timeouts 3 test cases with very large inputs. With smaller inputs, it works and does not terminate due to timeout. function minimumSwaps(arr) { let swaps = 0; for (let i = 0; i < arr.length; i++) { if (arr[i] === i + 1) continue; arr.splice(i, 1, arr.splice(arr.indexOf(i + 1), 1, arr[i])[0]); //swap swaps++; } return swaps; } I'm learning how to make it more performant, any help is welcome.
This is my solution to the Main Swaps 2 problem in JavaScript. It passed all the test cases. I hope someone finds it useful. //this function calls the mainSwaps function.. function minimumSwaps(arr){ let swaps = 0; for (var i = 0; i < arr.length; i++){ var current = arr[i]; var targetIndex = i + 1; if (current != targetIndex){ swaps += mainSwaps(arr, i); } } return swaps; } //this function is called by the minimumSwaps function function mainSwaps(arr, index){ let swapCount = 0; let currentElement = arr[index]; let targetIndex = currentElement - 1; let targetElement = arr[currentElement - 1]; while (currentElement != targetElement){ //swap the elements arr[index] = targetElement; arr[currentElement - 1] = currentElement; //increase the swapcount swapCount++; //store the currentElement, targetElement with their new values.. currentElement = arr[index]; targetElement = arr[currentElement - 1]; } return swapCount; } var myarray = [2,3,4,1,5]; var result = console.log(minimumSwaps(myarray));
you can also do it with a map. But its O(nlogn) const minSwaps = (arr) =>{ let arrSorted = [...arr].sort((a,b)=>a-b); let indexMap = new Map(); // fill the indexes for(let i=0; i<arr.length; i++){ indexMap.set(arr[i],i); } let count = 0; for(let i=0; i<arrSorted.length;i++){ if(arr[i] != arrSorted[i]){ count++; // swap the index let newIdx = indexMap.get(arrSorted[i]); indexMap.set(arr[i],newIdx); indexMap.set(arrSorted[i],i); // sawp the values [arr[i],arr[newIdx]] =[arr[newIdx],arr[i]]; } } return count; }
how can i make my function more efficient?
hey guys i wrote a function that compares array values and returns the minimum value but i want to know if there are ways to make it more efficient like iterating through all arrays (using one loop) and putting the results in a new array or making individual arrays sub-arrays of a single array, etc. Also the function provides the correct output but prints the answer three times: var nums1 = [-7528819, 3927361, -6398192]; var nums2 = [1777100, -2299720, -5566643]; var nums3 = [7188445, 3724971, 7699332]; var nums4 = [-8432528, -159836, -1604959]; var nums5 = [2764889, 4681472, 701396]; var nums6 = [-5073513, 599535, 4388457]; var nums7 = [8689640, 8028586, 1022322]; var nums8 = [-1088592, 1211232, -7868192]; var nums9 = [-5848613, -4945165, 631213]; var nums10 = [3218429, -833619, -1495854]; var nums11 = [8007060, 1637562, -7568493]; var nums12 = [-8391131, -6585338, 131787]; var nums13 = [-3957775, -9396892, -6143241]; var nums14 = [-6258442, -7829421, 3696922]; var nums15 = [2136598, 4935467, -1621605]; var nums16 = [-7162005, 9861954, 8977930]; var nums17 = [7226452, 8551594, 7006517]; var nums18 = [-1751226, -2536997, -1782251]; var nums19 = [380582, 1614389, 3272584]; var nums20 = [-8988205, -5167181, -7561034]; var nums21 = [-484059, -7160121, 4076528]; var nums22 = [1947448, -5551253, 7491190]; var numsLength = nums1.length; var i = 0; var minNum; function test(arr) { for (i; i < numsLength; i++) { if (arr[0] < arr[1] && arr[2]) { minNum = arr[0]; } else if (arr[1] < arr[2] && arr[0]) { minNum = arr[1]; } else if (arr[2] < arr[1] && arr[0]) { minNum = arr[2]; } console.log(minNum); } } test(nums1);
You could just use Math.min function. console.log(Math.min.apply(null, nums1));
Look at his snippet of code and read inline comments: var nums = []; // I'm pushing only 3 sets of data, but there can be any number // Also there can be any number of elements in each array as you can see nums.push([-7528819, 3927361, -6398192]); nums.push([1777100, -2299720, -5566643, 380582]); nums.push([7188445, 3724971, 7699332, 1947448, -5551253, 7491190]); function produceResults(nums) { var i, results = []; // gathering results for (i = 0; i < nums.length; i++) { results.push(Math.min.apply(null, nums[i])); } return results; } console.log(produceResults(nums)); So 2 suggestions: use more dynamic structure (array of arrays) instead of defining 22 arrays. use built in JS functions and components (Math.min)
Unrolling a loop is actually the most efficient implementation of a loop in most cases. However, practically speaking, unrolling a loop isn't usually feasible. With a small, fixed-size array, like those you have here, each permutation of the loop is obvious, and if your goal is raw speed you can't get much more efficient than what you have. That being said, the loop in your function is useless, as others have pointed out., because you've essentially unrolled the loop already. Also the syntax of the if statement is incorrect, and you are not handling the case where values in the array are equal. For fixed arrays of size three you want something more along the lines of... if (val1 <= val2 && val1 <= val3) { minVal = val1; } else if (val2 <= val1 && val2 <= val3) { minVal = val2; } else minVal = val3; Now if you want to do an arbitrary search for the min value of any size array you would do something similar, but using a loop, like... var minVal = null; for (var i = 0; i < arr.length; i++) { if (minVal === null || minVal > (val = arr[i])) minVal = val; } Depending on what you actually want to accomplish, and the size of the array, it might make sense to sort the array and rerurn the min (0 index) from the sorted array. If you go that route, start with a google search for "sort algorithms"
How to push into the second dimension of a two dimensional array in JavaScript?
I have a list of players in denoted as activeRange[x] where x will vary from day-to-day. Each of the x values will have to have AT LEAST 4 more subsequent values (likely a bit more). Ideally I'd like the array to look like: activeRange[x][y] So here's what I've done so far: var MATCH = AllData[TotalRows][TotalColumns+1]; activeRange[TotNumPlayers].push(MATCH); This is all located within 3 nested for loops. TotNumPlayers will iterate through a given set declared at the beginning (somewhat like 23). Once done, the TotalRows will iterate, then finally TotalColumns I'm running into the following error: TypeError: Cannot find function push in object mitch mitch is the value of activeRange[0]. I've been staring at this way too long, so any help would be appreciated! EDIT: Code inserted below: PLEASE IGNORE ALL THE COMMENTS. I COPY/PASTED THIS FROM A BIT OF CODE I USED YESTERDAY TO PERFORM A DIFFERENT FUNCTION. This is the second time I've ever posted on this website, so trying to format this monster to be pretty was scary sounding. Hopefully this is good enough. This is how activeRange was declared and initialized. var activeRange = new Array(); for (var b=0; b<=lastRow-2; b++){ activeRange[b] = sheetRANK.getRange(b+2,1).getValue(); } This is the function. function getTotalScore(activeRange, w) { Logger.clear() var ss = SpreadsheetApp.getActiveSpreadsheet(); var sheetWAR = ss.getSheetByName('WAR'); var sheetRANK = ss.getSheetByName('RANK'); var AllData = sheetRANK.getDataRange().getValues(); Logger.log('First'); for (var TotNumPlayers = 0; TotNumPlayers <= activeRange.length; TotNumPlayers++) { Logger.log('Second'); var f = 0; for (var TotalColumns = 0; TotalColumns <= AllData[0].length; ++TotalColumns) { // Init n. If n <= the total columns (second dimension), inc n. Logger.log('Third'); for (var TotalRows = 0; TotalRows <= AllData.length; ++TotalRows) { // Init i. If i <= the total rows (first dimension), inc i. Logger.log('Fourth'); //try{ // to avoid errors. if (activeRange[TotNumPlayers] != "") { Logger.log('Here?'); if (AllData[TotalRows][TotalColumns].valueOf().toUpperCase() == activeRange[TotNumPlayers].toUpperCase()) { Logger.log('How About Here?'); var MATCH = AllData[TotalRows][TotalColumns + 1]; activeRange.push(TotNumPlayers, MATCH); for (var Calc = 0; Calc <= activeRange[TotNumPlayers].length - 1; Calc++) { var OverallScore = ((activeRange[TotNumPlayers][0] * 1.0) + (activeRange[TotNumPlayers][1] * .75) + (activeRange[TotNumPlayers][2] * .50) + (activeRange[TotNumPlayers][3] * .25)); sheetRANK.getRange(activeRange[TotNumPlayers] + 1, 2).setValue(OverallScore); f = f + 1; } if (TotalRows == AllData.length - 1 && TotalColumns == AllData[0].length - 1 && f == 0) { Browser.msgBox('No names matching \'' + activeRange[TotNumPlayers] + '\' found. Check your spelling!'); return; } } } } } } }
Try thinking about what kind of data structures you can use to make your life easier. For this particular case, you have a list of players that you want to associate some data with. You'd probably use a structure like: activeRange = [ { name: 'mitch', data: [] } ] When you want to update the data, you'd simply call activeRange[0].data.push(someData). activeRange is an array of players and each player is represented by an object with some properties, (name, data, etc). Calling activeRange[0] yields the first player in your array and activeRange[0].data will yield the data associated with that player, which you can then manipulate however you want (push, pop, etc)
Based on your comments, you need a structure more like this var activeRange = [ { name: 'mitch', otherData: [ 10, 11, 12, 13 ] }, { name: 'viper', otherData: [ //values ] } ] you can access that by activeRange[0].otherData[2] to add to it, just push into the sub array activeRange[0].otherData.push(newValue)
Knapsack variant in JavaScript
I have tried to implement this knapsack problem solution algorithm in JavaScript, but the solutions s_opt I get has a total weight greater than the L_max. What am I doing wrong? I suspect it could be something related to Closures in recursion. /* GENERAL: Assume we have a knapsack and we want to bring as much stuff as possible. Of each thing we have several variants to choose from. Each of these variants have different value and takes different amount of space. DEFINITIONS: L_max = integer, size of the knapsack for the entire problem having N items l = matrix, having the elements l[i-1][j-1] representing the space taken by variant j of item i (-1 since indexing the matrices has index starting on zero, i.e. item i is stored at position i-1) p = matrix, having the elements p[i-1][j-1] representing the value given by by variant j of item i n = total number of items (used in a sub-problem) N = total number of items (used in the full problem, N >= n) s_opt = vector having the optimal combination of variant selections s_i, i.e. s_opt = arg max p_sum */ function knapsack(L_max,l,p) { // constructing (initializing) - they are private members var self = this; // in order for private functions to be able read variables this.N = l.length; var DCached = []; // this is only used by a private function so it doesnt need to made public using this.* this.s_opt = []; this.p_mean = null; this.L_max = L_max; // define public optimization function for the entire problem // when this is completed the user can read // s_opt to get the solution and // p_mean to know the quality of the solution this.optimize = function() { self.p_mean = D(self.N,self.L_max) / Math.max(1,self.N); } // define private sub-problem optimization function var D = function(n,r) { if (r<0) return -Infinity; if (n==0) return 0; if(DCached[n-1] != null) { if(DCached[n-1][r-1] != null) { return DCached[n-1][r-1]; } } var p_max = -Infinity; var p_sum; var J = l[n-1].length; for(var j = 0; j < J; j++) { p_sum = p[n-1][j] + D( n-1 , r - l[n-1][j] ); if(p_sum>p_max) { p_max = p_sum; self.s_opt[n-1] = j; } } DCached[n-1] = []; DCached[n-1][r-1] = p_max; return p_max; } } The client using this knapsack solver does the following: var knapsackSolution = new knapsack(5,l,p); knapsackSolution.optimize(); // now the client can access knapsackSolution.s_opt containing the solution.
I found a solution. When solving a sub-problem D(n,r) the code in the question returned the optimized value, but it didn't really manage the array s_opt in a proper way. In the modified solution, pasted below, I fixed this. Instead of only returning the optimized value of the knapsack also an array of chosen variants (e.g. the arg of the max) are returned. The cache is also modified to manage these two parts of the solution (both max value and arg max value). The code below also contains an additional feature addition. The user can now also pass a value maxComputingComplexity controlling the computational size of the problem in some kind of heuristic manner. /* GENERAL: Assume we have a knapsack and we want to bring as much stuff as possible. Of each thing we have several variants to choose from. Each of these variants have different value and takes different amount of space. The quantity of each variant is one. DEFINITIONS: L_max = integer, size of the knapsack, e.g. max number of letters, for the entire problem having N items l = matrix, having the elements l[i-1][j-1] representing the space taken by variant j of item i (-1 since indexing the matrices has index starting on zero, i.e. item i is stored at position i-1) p = matrix, having the elements p[i-1][j-1] representing the value given by by variant j of item i maxComputingComplexity = value limiting the product L_max*self.N*M_max in order to make the optimization complete in limited amount of time. It has a serious implication, since it may cut the list of alternatives so that only the first alternatives are used in the computation, meaning that the input should be well ordered n = total number of items (used in a sub-problem) N = total number of items (used in the full problem, N >= n) M_i = number of variants of item i s_i = which variant is chosen to pack of item i s = vector of elements s_i representing a possible solution r = maximum total space in the knapsack, i.e. sum(l[i][s_i]) <= r p_sum = sum of the values of the selected variants, i.e. sum(p[i][s_i] s_opt = vector having the optimal combination of variant selections s_i, i.e. s_opt = arg max p_sum In order to solve this, let us see p_sum as a function D(n,r) = p_sum (just seeing it as a function of the sub-problem n combined with the maximum total space r) RESULT: */ function knapsack(L_max,l,p,maxComputingComplexity) { // constructing (initializing) - they are private members var self = this; // in order for private functions to be able read variables this.N = l.length; var DCached = []; // this is only used by a private function so it doesnt need to made public using this.* //this.s_opt = []; //this.p_mean = null; this.L_max = L_max; this.maxComputingComplexity = maxComputingComplexity; //console.log("knapsack: Creating knapsack. N=" + N + ". L_max=" + L_max + "."); // object to store the solution (both big problem and sub-problems) function result(p_max,s_opt) { this.p_max = p_max; //max value this.s_opt = s_opt; //arg max value } // define public optimization function for the entire problem // when this is completed the user can read // s_opt to get the solution and // p_mean to know the quality of the solution // computing complexity O(L_max*self.N*M_max), // think O=L_max*N*M_max => M_max=O/L_max/N => 3=x/140/20 => x=3*140*20 => x=8400 this.optimize = function() { var M_max = Math.max(maxComputingComplexity / (L_max*self.N),2); //totally useless if not at least two console.log("optimize: Setting M_max =" + M_max); return D(self.N,self.L_max,M_max); //self.p_mean = mainResult.D / Math.max(1,self.N); // console.log... } // Define private sub-problem optimization function. // The function reads to "global" variables, p and l // and as arguments it takes // n delimiting the which sub-set of items to be able to include (from p and l) // r setting the max space that this sub-set of items may take // Based on these arguments the function optimizes D // and returns // D the max value that can be obtained by combining the things // s_opt the selection (array of length n) of things optimizing D var D = function(n,r,M_max) { // Start by checking whether the value is already cached... if(DCached[n-1] != null) { if(DCached[n-1][r-1] != null) { //console.log("knapsack.D: n=" + n + " r=" + r + " returning from cache."); return DCached[n-1][r-1]; } } var D_result = new result(-Infinity, []); // here we will manage the result //D_result.s_opt[n-1] = 0; // just put something there to start with if (r<0) { //D_result.p_max = -Infinity; return D_result; } if (n==0) { D_result.p_max = 0; return D_result; } var p_sum; //self.s_opt[n] = 0; not needed var J = Math.min(l[n-1].length,M_max); var D_minusOneResult; //storing the result when optimizing all previous items given a max length for(var j = 0; j < J; j++) { D_minusOneResult = D( n-1 , r - l[n-1][j] , M_max) p_sum = p[n-1][j] + D_minusOneResult.p_max; if(p_sum > D_result.p_max) { D_result.p_max = p_sum; D_result.s_opt = D_minusOneResult.s_opt; D_result.s_opt[n-1] = j; } } DCached[n-1] = []; DCached[n-1][r-1] = D_result; //console.log("knapsack.D: n=" + n + " r=" + r + " p_max= "+ p_max); return D_result; } }
Aggregating JavaScript array into several arrays with different element lengths?
I have an array with 101 values (representing people aged 0-100). What would be a preferably fast and simple way of building these aggregated arrays in one go: var input = [55,33,12 .. 98 more] var output = { //same as input i1 = [], //0-5, 6-10, 11-15 ... 96-100 i5 = [], //0-10, 11-20, 21-30 ... 91-100 i10 = [], //0-20, 21-40, 41-60 ... 81-100 i20 = [], } On a side note: Would you name these aggregate arrays by the interval ("i1", "i5") or by the number of groups/elements ("g100", "g20") - what is more intuitive if another programmers comes across these definitions?
You can reuse results of the aggregation to calculate the next array. // sums up each n numbers from the input array // function groupSum(inarray, n) { var outarray = []; var sum = 0; for (var i = 0; i < inarray.length; i++) { sum += inarray[i]; if (i % n == n - 1) {outarray.push(sum); sum = 0;} } // add the last element if (i % n != 0) { outarray.push(sum); } return outarray; } var input = [55, 33, 12, 98, /* more numbers here */ 3, 4, 1, 2, 0, 7]; var output = {}; output.i1 = input; output.i5 = groupSum(output.i1, 5); output.i10 = groupSum(output.i5, 2); output.i20 = groupSum(output.i10, 2); Note that, as xanatos said, performance is not really of big concern here. PS1: was not sure if you were trying to make output an object (as in this code) or 2D array. PS2: since your first group always has 1 more element, you might need to adjust the code a bit for this special case.